Add an attention-getter to the Sneak Peek Context Menu |
||||
Issue descriptionIt would be nice to have an IPH bubble to draw attention to the "Sneak peek" menu item for users that use "Open in new tab" for the same purpose. I think we can start gathering the data for this now, by tracking users that "Open in new tab" and then immediately navigate to that tab. OTOH we may not need it if Sneak peek gets enough traction without the bubble.
,
Nov 17
,
Jan 9
This change should have been applied to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f7c3fbf144d5e84ac32bb4cfa5c054753b88457 commit 7f7c3fbf144d5e84ac32bb4cfa5c054753b88457 Author: Donn Denman <donnd@chromium.org> Date: Fri Nov 30 01:53:52 2018 [Ephemeral Tab] Add "*New*" to the menu title. Changes the title of the menu item from "Sneak peek" to "*New* Sneak peek" to help draw attention to the new choice. BUG=894619 Change-Id: I1446b191e8891f17452762b5dda4d6203c332510 Reviewed-on: https://chromium-review.googlesource.com/c/1355252 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#612504} [modify] https://crrev.com/7f7c3fbf144d5e84ac32bb4cfa5c054753b88457/chrome/android/java/strings/android_chrome_strings.grd
,
Jan 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57d6795942fc4636a53a092b46363aaa7a93a34e commit 57d6795942fc4636a53a092b46363aaa7a93a34e Author: Donn Denman <donnd@chromium.org> Date: Sat Jan 12 02:10:21 2019 [ET] Update *New* text styling in the context menu. This makes the "New" text be a superscript, smaller, and colored. This also makes some minor updates to the SpanApplier: 1) Ability to apply multiple spans to the same region. 2) Changes the doc to say that applying a null span does nothing. BUG= 902140 Change-Id: Ifb49fa091d7a2f8a0e07e5ab8b12299eba33d585 Reviewed-on: https://chromium-review.googlesource.com/c/1393674 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#622265} [modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsCustomContextMenuItem.java [modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java [modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItem.java [modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java [modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/ui/android/java/src/org/chromium/ui/text/SpanApplier.java [modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/ui/android/junit/src/org/chromium/ui/text/SpanApplierTest.java
,
Jan 12
Fixed. We will probably want to remove the "New" either before full rollout or before going Beta. Once we have UX help we can start addressing questions like this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by donnd@google.com
, Nov 6