New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO till 2/25
Closed: Jan 12
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 894619



Sign in to add a comment
link

Issue 902140: Add an attention-getter to the Sneak Peek Context Menu

Reported by donnd@google.com, Nov 6 Project Member

Issue description

It would be nice to have an IPH bubble to draw attention to the "Sneak peek" menu item for users that use "Open in new tab" for the same purpose.  I think we can start gathering the data for this now, by tracking users that "Open in new tab" and then immediately navigate to that tab.  OTOH we may not need it if Sneak peek gets enough traction without the bubble.
 

Comment 1 by donnd@google.com, Nov 6

Cc: huayinz@chromium.org
Theresa, thanks for the tip about highlighting views.  I tried to make this work with a single menu item but it seems that the context menu is all one view without sub-views.
Becky, do you know if the above is correct?  Maybe we can use a pager-view (ViewPageAdapter) to create a view for the single menu item we want to highlight?

Using an IPH bubble for a single menu item seem problematic because it will cover up other items, so using the highlight Theresa mentioned seems best.

twellington@ wrote on the other issue: I'd look at the in-product help for the download manager that highlights a menu item as a good example of how to do in-product help for a list item. Checkout the code in AppMenu.java related to higlightedItemId.

Another approach would be to just use the text of the menu item to draw attention, e.g. "*Try*: Sneak peek" until the user selects it, then revert to the normal wording.

Comment 2 by donnd@google.com, Nov 17

Labels: -OS-Chrome

Comment 3 by donnd@google.com, Jan 9

Summary: Add an attention-getter to the Sneak Peek Context Menu (was: Consider adding IPH for Sneak Peek Context Menu)
This change should have been applied to this bug:

  https://chromium.googlesource.com/chromium/src.git/+/7f7c3fbf144d5e84ac32bb4cfa5c054753b88457

commit 7f7c3fbf144d5e84ac32bb4cfa5c054753b88457
Author: Donn Denman <donnd@chromium.org>
Date: Fri Nov 30 01:53:52 2018

[Ephemeral Tab] Add "*New*" to the menu title.

Changes the title of the menu item from "Sneak peek" to
"*New* Sneak peek" to help draw attention to the new choice.

BUG=894619

Change-Id: I1446b191e8891f17452762b5dda4d6203c332510
Reviewed-on: https://chromium-review.googlesource.com/c/1355252
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612504}
[modify] https://crrev.com/7f7c3fbf144d5e84ac32bb4cfa5c054753b88457/chrome/android/java/strings/android_chrome_strings.grd

Comment 4 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57d6795942fc4636a53a092b46363aaa7a93a34e

commit 57d6795942fc4636a53a092b46363aaa7a93a34e
Author: Donn Denman <donnd@chromium.org>
Date: Sat Jan 12 02:10:21 2019

[ET] Update *New* text styling in the context menu.

This makes the "New" text be a superscript, smaller, and colored.

This also makes some minor updates to the SpanApplier:
1) Ability to apply multiple spans to the same region.
2) Changes the doc to say that applying a null span does nothing.

BUG= 902140 

Change-Id: Ifb49fa091d7a2f8a0e07e5ab8b12299eba33d585
Reviewed-on: https://chromium-review.googlesource.com/c/1393674
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622265}
[modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsCustomContextMenuItem.java
[modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
[modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItem.java
[modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
[modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/ui/android/java/src/org/chromium/ui/text/SpanApplier.java
[modify] https://crrev.com/57d6795942fc4636a53a092b46363aaa7a93a34e/ui/android/junit/src/org/chromium/ui/text/SpanApplierTest.java

Comment 5 by donnd@google.com, Jan 12

Status: Fixed (was: Assigned)
Fixed.  We will probably want to remove the "New" either before full rollout or before going Beta.  Once we have UX help we can start addressing questions like this.

Sign in to add a comment