Enable logs in Guest mode for Files app, Gallery, Audio Player and Video Player |
||
Issue descriptionCurrently in Guest mode we don't have any entries for console.log in those apps. This makes very hard to debug failing tests in Guest mode to make things worst Guest mode tests tend to be more flaky. It seems that the logic to filter these logs already whitlists WebUI URLs because they're web pages that are part of Chrome. These component apps are also part of ChromeOS, so they can follow the same logic and have their logs whitelisted.
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a commit d54e23f900fbb70f31fec14c1c224cbbf5cfc03a Author: Sam McNally <sammc@chromium.org> Date: Wed Jan 16 04:42:39 2019 Pass through incognito console messages for component apps/extensions. By default, JS console logging is forwarded to the C++ base logging system. This logging is disabled in incognito, except for WebUI since it is part of Chrome. That it may run in an incognito renderer process is an implementation detail; its logging should be recorded just like any native component. Dropping JS logging from incognito web content results in guest mode Files app tests producing no output, making debugging their failures difficult. Component apps/extensions are logically part of Chrome just like WebUI, with the component app/extension nature an implementation detail. Add an exception for component apps/extensions to the incognito logging exclusion. Also apply this criterion for determining whether to preserve log level from JS logging. Like WebUI, component apps/extensions should be able to log at the log level of their choosing. Bug: 902136 Change-Id: I9a118873a601ec87949b63ae7e4937cf432c23fa Reviewed-on: https://chromium-review.googlesource.com/c/1408729 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#623108} [modify] https://crrev.com/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc [modify] https://crrev.com/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h [modify] https://crrev.com/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a/content/public/browser/content_browser_client.cc [modify] https://crrev.com/d54e23f900fbb70f31fec14c1c224cbbf5cfc03a/content/public/browser/content_browser_client.h
,
Jan 16
|
||
►
Sign in to add a comment |
||
Comment 1 by lucmult@chromium.org
, Nov 5