New issue
Advanced search Search tips

Issue 902107 link

Starred by 1 user
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Nov 8
Cc:
katie@chromium.org
yawano@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Crash in ARC++ accessibility when using Aqua Mail

Project Member Reported by dtseng@google.com, Nov 5 
- in Aqua mail
- go through initial flow
- gmail
- next
- click on your user account

result:

#0  arc::ArcAccessibilityHelperBridge::OnAction(ui::AXActionData const&) const ()
    at ../../chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc:495
warning: (Internal error: pc 0x57534f889f00 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57534f88a0b7 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57534f88a0b7 in read in CU, but not in symtab.)
warning: Could not find DWO CU obj/chrome/browser/extensions/extensions/automation_internal_api.dwo(0xa1b819acf40e8a22) referenced by CU at offset 0x11da6d [in module /opt/google/chrome/chrome]
warning: (Internal error: pc 0x57535470394e in read in CU, but not in symtab.)
warning: (Internal error: pc 0x575354703870 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57535470394e in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57535470394e in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57535470394e in read in CU, but not in symtab.)
#1  0x000057535470394f in extensions::AutomationInternalPerformActionFunction::Run() ()
    at ../../chrome/browser/extensions/api/automation_internal/automation_internal_api.cc:486
warning: (Internal error: pc 0x57535470394e in read in CU, but not in symtab.)
warning: Could not find DWO CU obj/extensions/browser/browser_sources/extension_function.dwo(0xdb7f8b666c939239) referenced by CU at offset 0x3dabd [in module /opt/google/chrome/chrome]
warning: (Internal error: pc 0x57534f497b11 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57534f497ac0 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57534f497b11 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57534f497b11 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57534f497b11 in read in CU, but not in symtab.)
#2  0x000057534f497b12 in ExtensionFunction::RunWithValidation() ()
    at ../../extensions/browser/extension_function.cc:451
warning: (Internal error: pc 0x57534f497b11 in read in CU, but not in symtab.)
warning: Could not find DWO CU obj/extensions/browser/browser_sources/extension_function_dispatcher.dwo(0x8321eb2a549b868d) referenced by CU at offset 0x3db15 [in module /opt/google/chrome/chrome]

Comment 1 by dtseng@google.com, Nov 5 

The Android side crash is

11-05 14:56:50.731  1909  1909 E AndroidRuntime: FATAL EXCEPTION: main
11-05 14:56:50.731  1909  1909 E AndroidRuntime: Process: org.chromium.arc.accessibilityhelper, PID: 1909
11-05 14:56:50.731  1909  1909 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.CharSequence android.view.accessibility.AccessibilityNodeInfo.getPackageName()' on a null object reference
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at org.chromium.arc.accessibilityhelper.ArcAccessibilityHelperService.onAccessibilityEvent(ArcAccessibilityHelperService.java:529)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at android.accessibilityservice.AccessibilityService$2.onAccessibilityEvent(AccessibilityService.java:1538)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at android.accessibilityservice.AccessibilityService$IAccessibilityServiceClientWrapper.executeMessage(AccessibilityService.java:1724)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at com.android.internal.os.HandlerCaller$MyHandler.handleMessage(HandlerCaller.java:37)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:193)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6852)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
11-05 14:56:50.731  1909  1909 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:865)

@yawano, have you seen this NPE before?

Comment 2 by yawano@chromium.org, Nov 6 

I think it can be null. But if I check source code, I think we are already doing null check there.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5568b9ca96fcccdc027aa0cc49e3a453edaf465c

commit 5568b9ca96fcccdc027aa0cc49e3a453edaf465c
Author: David Tseng <dtseng@chromium.org>
Date: Wed Nov 07 19:19:38 2018

Ensure there is a valid ARC bridge service when performing an a11y action

It is possible that, before performing an action, the ARC++ container crashed.

Ensure that we don't also crash Chrome by dereferencing nullptr.

Bug:  902107 
Change-Id: I09de402a41dfead09cee4685bc610a227740f9a5
Reviewed-on: https://chromium-review.googlesource.com/c/1318740
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606117}
[modify] https://crrev.com/5568b9ca96fcccdc027aa0cc49e3a453edaf465c/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc

Comment 4 by dtseng@chromium.org, Nov 8

Status: Fixed (was: Assigned)
Chrome and ARC changes landed.
►

Sign in to add a comment