Window dragging in overview mode should not trigger occlusion state change |
||||
Issue descriptionOcclusion change during dragging is temporay and should not cause occlusion change until it's droppoed. This can cause jank when dragging window in overview mode, for example.
,
Nov 8
,
Nov 14
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8bda0294295e0d0345982fe7dc15c8235b75f27 commit b8bda0294295e0d0345982fe7dc15c8235b75f27 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Nov 14 23:05:07 2018 Exclude dragged window in tablet overview mode from occlusion tracking. * Add ScopdExclude class. The window specified will be ignored in occlusion tracking process. * Exclude the dragging window in overview mode. Bug: 902074 Test: covered by unit tests. Manaully tested on slate and make sure that dragging window in tablet overview mode doesn't not trigger frame evictor. Change-Id: I4312f2dbc1928ac7cbbd4eac562547e7009fdbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1318360 Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608157} [modify] https://crrev.com/b8bda0294295e0d0345982fe7dc15c8235b75f27/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc [modify] https://crrev.com/b8bda0294295e0d0345982fe7dc15c8235b75f27/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.h [modify] https://crrev.com/b8bda0294295e0d0345982fe7dc15c8235b75f27/ui/aura/window_occlusion_tracker.cc [modify] https://crrev.com/b8bda0294295e0d0345982fe7dc15c8235b75f27/ui/aura/window_occlusion_tracker.h [modify] https://crrev.com/b8bda0294295e0d0345982fe7dc15c8235b75f27/ui/aura/window_occlusion_tracker_unittest.cc
,
Dec 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by osh...@chromium.org
, Nov 8