New issue
Advanced search Search tips

Issue 902050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: AccessibilityWinBrowserTest.TestNotificationChildrenChanged
Team-Accessibility



Sign in to add a comment

AccessibilityWinBrowserTest.TestNotificationChildrenChanged is flaky

Project Member Reported by Findit, Nov 5

Issue description


Flaky test: AccessibilityWinBrowserTest.TestNotificationChildrenChanged
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/45196
Test output log: https://chromium-swarm.appspot.com/task?id=40fe6a87bd714710
Culprit (75.2% confidence): r605372
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKMAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ1MTk2L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1FXTmpaWE56YVdKcGJHbDBlVmRwYmtKeWIzZHpaWEpVWlhOMExsUmxjM1JPYjNScFptbGpZWFJwYjI1RGFHbHNaSEpsYmtOb1lXNW5aV1E9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20AccessibilityWinBrowserTest.TestNotificationChildrenChanged&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKMAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ1MTk2L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1FXTmpaWE56YVdKcGJHbDBlVmRwYmtKeWIzZHpaWEpVWlhOMExsUmxjM1JPYjNScFptbGpZWFJwYjI1RGFHbHNaSEpsYmtOb1lXNW5aV1E9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Components: UI>Accessibility
Owner: futhark@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
A new attempt which explicitly updates the AXObjectCache:

https://chromium-review.googlesource.com/c/chromium/src/+/1319610

Labels: -Pri-1 Pri-2
Reduced pri since offender was reverted.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a9ef4599aa9e6cb6fdc27484ac50fcfdda9482

commit 18a9ef4599aa9e6cb6fdc27484ac50fcfdda9482
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Nov 06 12:08:12 2018

Full AttachLayoutTree on a new Document not necessary.

We called AttachLayoutTree on a new Document which just got its
LayoutView created. The new Document should not have any child nodes,
it's not marked initially dirty, but trying to land this change the
first time we caused flakiness for a Window accessibility test.

Instead of the AttachLayoutTree call, do the AXObjectCache update which
would otherwise be called from Node::AttachLayoutTree.

This is a new attempt after the previous got reverted:

https://chromium-review.googlesource.com/c/chromium/src/+/1317889

Bug:  902050 
Change-Id: I4e366013549627b54f016d76b3dcbf12ea115f70
Reviewed-on: https://chromium-review.googlesource.com/c/1319610
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605657}
[modify] https://crrev.com/18a9ef4599aa9e6cb6fdc27484ac50fcfdda9482/third_party/blink/renderer/core/dom/document.cc

Status: Fixed (was: Started)
Let's see if this sticks.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d941a8393d4275d5d4cfa69285e45436f43e25a1

commit d941a8393d4275d5d4cfa69285e45436f43e25a1
Author: Dmitry Titov <dimich@chromium.org>
Date: Tue Nov 06 22:02:34 2018

Revert "Full AttachLayoutTree on a new Document not necessary."

This reverts commit 18a9ef4599aa9e6cb6fdc27484ac50fcfdda9482.

Reason for revert: Broke the accessibility test (again): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/29232

Please note this does not look like a flake, after this landed a dozen runs failed consistently. 

Original change's description:
> Full AttachLayoutTree on a new Document not necessary.
> 
> We called AttachLayoutTree on a new Document which just got its
> LayoutView created. The new Document should not have any child nodes,
> it's not marked initially dirty, but trying to land this change the
> first time we caused flakiness for a Window accessibility test.
> 
> Instead of the AttachLayoutTree call, do the AXObjectCache update which
> would otherwise be called from Node::AttachLayoutTree.
> 
> This is a new attempt after the previous got reverted:
> 
> https://chromium-review.googlesource.com/c/chromium/src/+/1317889
> 
> Bug:  902050 
> Change-Id: I4e366013549627b54f016d76b3dcbf12ea115f70
> Reviewed-on: https://chromium-review.googlesource.com/c/1319610
> Reviewed-by: Anders Ruud <andruud@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605657}

TBR=futhark@chromium.org,andruud@chromium.org

Change-Id: Ied8ff9426940489ac4693abdb34001f44b13478c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  902050 
Reviewed-on: https://chromium-review.googlesource.com/c/1321229
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605839}
[modify] https://crrev.com/d941a8393d4275d5d4cfa69285e45436f43e25a1/third_party/blink/renderer/core/dom/document.cc

Status: Assigned (was: Fixed)
Indeed, the revert fixed the build after several builds reliably failed since it was landed: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/29236

Since test replaces innerHTML and then verifies DOM it might be affected somehow. Not sure but landing this patch twice, failing the same test and fixing it after 2 reverts definitely makes it related... 
Status: Fixed (was: Assigned)
I'll not try to reland the offending patch in any form at this point. Closing.

Sign in to add a comment