[MacOS host] Provide more context to the user when displaying the permission prompt for input injection |
||
Issue descriptionIn order to notify the user that CRD requires additional permissions to inject input (and ask them to allow us access to the APIs), we use a MacOS API to display a prompt: https://cs.chromium.org/chromium/src/remoting/host/mac/permission_utils.mm?rcl=c584481ad55bcbd3bdeaf337d2f44d061fb7bd4d&l=18 We cannot modify the text in the prompt so it is generic and references the wrapper script we register with LaunchD. We should provide a dialog (Alert w/ OK) which tells the user what we need and why the dialog is going to be displayed. That way they have more context when the platform dialog is shown. I will also chat with a few folks to get a feel for how important this is, we may decide to skip it.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d76a59d7d13b2e5bdf1ea6c78b3c8286bff974b commit 3d76a59d7d13b2e5bdf1ea6c78b3c8286bff974b Author: Joe Downing <joedow@google.com> Date: Wed Nov 14 19:02:55 2018 Updating MacOS Host icns files to use the current CRD logo As part of the permission dialog work, I want to make sure that the icon displayed in the dialog matches that of the Chrome app and other clients (instead of the older icon which had two blue rectangles). The concern is that the outdated icon may make the dialog look less trustworthy and users might dismiss it outright instead of reading it. Bug: 902041 , 757618 Change-Id: Ia69ea7dab6d7d246302b75b199831c4048935888 Reviewed-on: https://chromium-review.googlesource.com/c/1336058 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#608069} [modify] https://crrev.com/3d76a59d7d13b2e5bdf1ea6c78b3c8286bff974b/remoting/host/installer/mac/uninstaller/remoting_uninstaller.icns [modify] https://crrev.com/3d76a59d7d13b2e5bdf1ea6c78b3c8286bff974b/remoting/host/mac/remoting_me2me_host.icns
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/090ba542bdc6cd21fb8e4ec93d6b780c7d7e1fc0 commit 090ba542bdc6cd21fb8e4ec93d6b780c7d7e1fc0 Author: Joe Downing <joedow@google.com> Date: Thu Nov 15 00:37:02 2018 Strings for Mojave Permission Dialog Checking in the strings early to get a jump on localization. Bug: 902041 Change-Id: I697462486441a009b36f31955f61633946410ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1336084 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#608195} [modify] https://crrev.com/090ba542bdc6cd21fb8e4ec93d6b780c7d7e1fc0/remoting/resources/remoting_strings.grd [add] https://crrev.com/090ba542bdc6cd21fb8e4ec93d6b780c7d7e1fc0/remoting/resources/remoting_strings_grd/IDS_ACCESSIBILITY_PERMISSION_DIALOG_BODY_TEXT.png.sha1 [add] https://crrev.com/090ba542bdc6cd21fb8e4ec93d6b780c7d7e1fc0/remoting/resources/remoting_strings_grd/IDS_ACCESSIBILITY_PERMISSION_DIALOG_NOT_NOW_BUTTON.png.sha1 [add] https://crrev.com/090ba542bdc6cd21fb8e4ec93d6b780c7d7e1fc0/remoting/resources/remoting_strings_grd/IDS_ACCESSIBILITY_PERMISSION_DIALOG_OPEN_BUTTON.png.sha1 [add] https://crrev.com/090ba542bdc6cd21fb8e4ec93d6b780c7d7e1fc0/remoting/resources/remoting_strings_grd/IDS_ACCESSIBILITY_PERMISSION_DIALOG_TITLE.png.sha1
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86e2e34cad7e88a18901c6c20afc377b739dbde9 commit 86e2e34cad7e88a18901c6c20afc377b739dbde9 Author: Joe Downing <joedow@google.com> Date: Thu Nov 15 19:29:29 2018 [MacOS Host] Replacing system dialog with custom permission dialog This CL replaces the confusing, generic, platform provided permission dialog on Mojave with one which provides more context and instructions on what the user needs to do to enable Chrome Remote Desktop on Mojave. Bug: 902041 Change-Id: Ibda9459dfba3579c596cf5e2703b8c3d0ea28059 Reviewed-on: https://chromium-review.googlesource.com/c/1334838 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#608473} [modify] https://crrev.com/86e2e34cad7e88a18901c6c20afc377b739dbde9/remoting/host/mac/permission_utils.h [modify] https://crrev.com/86e2e34cad7e88a18901c6c20afc377b739dbde9/remoting/host/mac/permission_utils.mm [modify] https://crrev.com/86e2e34cad7e88a18901c6c20afc377b739dbde9/remoting/host/remoting_me2me_host.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65453a440605372260c3303c9f8a6c14aba1c759 commit 65453a440605372260c3303c9f8a6c14aba1c759 Author: Joe Downing <joedow@google.com> Date: Wed Nov 28 18:12:40 2018 [MacOS Host] Fixing a memory leak in the alert dialog Follow-up CL fixing a leak identified post check-in. Bug: 902041 Change-Id: Ic900c107f13185fa8c823163b2278990ed543ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1352030 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#611777} [modify] https://crrev.com/65453a440605372260c3303c9f8a6c14aba1c759/remoting/host/mac/permission_utils.mm
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0793ae771a657373792c0cca7ac52964bed51741 commit 0793ae771a657373792c0cca7ac52964bed51741 Author: Ken Rockot <rockot@google.com> Date: Wed Nov 28 19:08:39 2018 Revert "[MacOS Host] Fixing a memory leak in the alert dialog" This reverts commit 65453a440605372260c3303c9f8a6c14aba1c759. Reason for revert: broke the build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928590708886404784/+/steps/compile/0/stdout Original change's description: > [MacOS Host] Fixing a memory leak in the alert dialog > > Follow-up CL fixing a leak identified post check-in. > > Bug: 902041 > Change-Id: Ic900c107f13185fa8c823163b2278990ed543ff2 > Reviewed-on: https://chromium-review.googlesource.com/c/1352030 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611777} TBR=joedow@chromium.org,rsesek@chromium.org Change-Id: I346b4a43995959ce2c289d5f2ff31feb722b4233 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902041 Reviewed-on: https://chromium-review.googlesource.com/c/1354231 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611806} [modify] https://crrev.com/0793ae771a657373792c0cca7ac52964bed51741/remoting/host/mac/permission_utils.mm
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74ff22e5a690f07fd6a202246becc6790392e11b commit 74ff22e5a690f07fd6a202246becc6790392e11b Author: Joe Downing <joedow@google.com> Date: Thu Nov 29 19:08:30 2018 [MacOS Host] Fixing a memory leak in the alert dialog Follow-up CL fixing a leak identified post check-in. Bug: 902041 Change-Id: I733cc6037f5c29f0decabae72d51a6470de17f91 Reviewed-on: https://chromium-review.googlesource.com/c/1355332 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#612298} [modify] https://crrev.com/74ff22e5a690f07fd6a202246becc6790392e11b/remoting/host/mac/permission_utils.mm
,
Jan 9
|
||
►
Sign in to add a comment |
||
Comment 1 by joedow@chromium.org
, Nov 12