New issue
Advanced search Search tips

Issue 902026 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

kernel-v4.19: bad git usage breaks out of tree builds

Project Member Reported by vapier@chromium.org, Nov 5

Issue description

looks like a CL cherry pick is missing from the 4.19 branch ?  out of tree builds are failing w/4.19 because tools are writing to write to the source repo.

  make[1]: Entering directory '/build/cheza/var/cache/portage/sys-kernel/chromeos-kernel-4_19'
   GEN     ./Makefile
  * ACCESS DENIED:  open_wr:      /mnt/host/source/src/third_party/kernel/v4.19/.git/index.lock

 make[1]: Leaving directory '/build/cheza/var/cache/portage/sys-kernel/chromeos-kernel-4_19'
 >>> Source compiled.
  * --------------------------- ACCESS VIOLATION SUMMARY ---------------------------
  * LOG FILE: "/var/log/sandbox/sandbox-27958.log"
  * 
 VERSION 1.0
 FORMAT: F - Function called
 FORMAT: S - Access Status
 FORMAT: P - Path as passed to function
 FORMAT: A - Absolute Path (not canonical)
 FORMAT: R - Canonical Path
 FORMAT: C - Command Line
 
 F: open_wr
 S: deny
 P: /mnt/host/source/src/third_party/kernel/v4.19/.git/index.lock
 A: /mnt/host/source/src/third_party/kernel/v4.19/.git/index.lock
 R: /mnt/host/source/src/third_party/kernel/v4.19/.git/index.lock
 C: git status -uno --porcelain 
  * --------------------------------------------------------------------------------

can test with the CL here:
  https://chromium-review.googlesource.com/1316147
 
I am confused. Subject says 4.14, text says 4.19, and a missing CL is mentioned in the subject but there is no mention what that missing CL might be.

Cc: vapier@chromium.org
Summary: kernel-v4.19: bad git usage breaks out of tree builds (was: kernel-v4.14: bad git usage breaks out of tree builds)
sorry, meant 4.19, not 4.14

wrt necessary CL, i don't know.  i vaguely recall us landing stuff in the past to make the git usage in the tree read-only.  maybe some newer logic was added since 4.14 that caused it to regress.
Labels: Kernel-4.19
Status: Started (was: Available)
Culprit is upstream commit 6147b1cf19651 ("scripts/setlocalversion: git: Make -dirty check more robust"). This commit introduces the use of "git status -uno --porcelain" which tries to lock the git repository.

Status: Fixed (was: Started)

Sign in to add a comment