"mb.py zip chrome" misses chrome.exe on Windows |
||||
Issue descriptionChrome Version: ToT checkout OS: Win10 What steps will reproduce the problem? (1) On Windows, inside a Chromium checkout, run: vpython tools\mb\mb.py zip out\Release chrome out\chrome.zip (2) Unzip the generated zip archive What is the expected result? Expect the unzipped out\Release to contain the Chrome executable and all supporting libraries. What happens instead? chrome.exe is missing from the zip archive. Am I building and attempting to package the wrong target? This makes it difficult to ship binaries to colleagues for testing. (I'll use mini_installer for this purpose, but want to be able to package a bare Chromium build.) Thanks.
,
Nov 5
Looks like the "chrome" target in src/chrome/BUILD.gn is just a group. I tried adding a "raw" type target for chrome_initial in src/testing/buildbot/gn_isolate_map.pyl, and that didn't work (the zip for chrome_initial had the same contents as that for chrome). Also tried changing the type for "chrome" from "additional_compile_target" to "raw"; didn't work either.
,
Nov 6
Dirk, could I ask you or someone else on I>C>C to take a look at this packaging script? Thanks much.
,
Nov 8
I didn't get a chance to look at this on my shift, and also don't know much about the how MB creates the zip file.
,
Nov 8
This is really a bug in the build more than an infra thing. MB just does what GN tells it to do. So, someone needs to figure out why :chrome_initial isn't listed as a data dependency of :chrome.
,
Nov 8
Thanks Stephen and Dirk. Let me email chromium-dev about this.
,
Nov 8
I can at least fire up a windows checkout and take a quick look, so let me do that now before you email the list. If you don't see a CL w/ a fix from me in the next half hour, assume I failed to get to this :).
,
Nov 8
Oops, sorry, I already emailed chromium-dev. Please feel free to reply there if you find a fix; thanks. :)
,
Nov 8
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d93d4102d04411f2432716d7de7fcc5dff9c881 commit 9d93d4102d04411f2432716d7de7fcc5dff9c881 Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Nov 08 20:24:38 2018 Fix missing data_deps on //chrome:chrome on Windows. The //chrome:chrome group was missing a data_deps declaration on //chrome:reorder_imports, which meant that chrome would build fine but if you ran `mb zip //out/Release //chrome` you'd only get the copy in //out/Release/initialexe/chrome.exe and not the final version in //out/Release. Bug: 902010 Change-Id: I0f3b662ced4c34eef974e8bede01fb9c89410dc1 Reviewed-on: https://chromium-review.googlesource.com/c/1325554 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606586} [modify] https://crrev.com/9d93d4102d04411f2432716d7de7fcc5dff9c881/chrome/BUILD.gn
,
Nov 16
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Nov 5