New issue
Advanced search Search tips

Issue 902000 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Check Blink.Canvas/OffscreenCanvas.SqrtNumberOfPixels values

Project Member Reported by fs...@chromium.org, Nov 5

Issue description

Check why we are getting so much 202 buckets.
 
It's if a canvas is created without size, e.g. `document.createElement("canvas")` it's instantiated with a size of 300x150. `sqrt(300 * 150) = 212.13` which is in the 202-217 bucket.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff6da4e16a772f2026a129de8cba0951c2cc85f6

commit ff6da4e16a772f2026a129de8cba0951c2cc85f6
Author: Aaron Krajeski <aaronhk@google.com>
Date: Wed Nov 07 16:12:15 2018

Move canvas and offscreenCanvas size recorders to their destructors

This prevents us from recording canvas size multiple times for the same
canvas. Also confirmed that we are recording the correct numbers and
move `isOffscreen` to an enum.

Bug:  902000 
Change-Id: Ic6e66ec960ae0166699280303a61b574c9320294
Reviewed-on: https://chromium-review.googlesource.com/c/1319180
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606062}
[modify] https://crrev.com/ff6da4e16a772f2026a129de8cba0951c2cc85f6/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/ff6da4e16a772f2026a129de8cba0951c2cc85f6/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/ff6da4e16a772f2026a129de8cba0951c2cc85f6/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/ff6da4e16a772f2026a129de8cba0951c2cc85f6/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc

Status: Fixed (was: Assigned)

Sign in to add a comment