Fix padding in system tray |
||||||
Issue descriptionCurrent padding doesn't match the spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZXS6M2rSjiqy/files/MCGWDM8eaujQbl-tc0V_WItowMSJbxAVNpw
,
Nov 7
,
Nov 7
Issue 884651 has been merged into this issue.
,
Nov 7
Thanks Sébastien. So if I read the spec correctly (and assuming a left-to-right UI), the padding to the *right* of each of these is: * 4px to the right of input language, notification badge, and family link * 0 to the right of the clock (which is always at the far right) -- just the padding already built into the area * 2px to the right of everything else Let me know if I misundersood anything :-)
,
Nov 7
Removing Google restriction.
,
Nov 7
I actually expressed the spec in a confusing way. The goal is to compensate for the vertical aspect ratio of the battery, therefore, there should always be 2px padding left and right of the battery, everything else should have 4px padding. See following configuration (excluding side padding) - Notification |4px| Cell |2px| Battery |2px| Clock - Do not disturb |4px| Cell |4px| Wifi |2px| Battery |2px| Clock - Keyboard language |4px| Device management Cell |4px| Wifi |2px| Battery |2px| Clock - Notification |4px| Clock For the latter - No battery use case- which happens on Chromebox, you'll notice the padding is 4px between notification icons and Clock.
,
Nov 7
Understood, thanks a lot for clarifying!
,
Nov 7
Maybe a simpler way to say that is: * All these widgets have a left and right margin of 2 px * Except for the battery, which has only 1 px of left and right margin * The rightmost item has no right margin, and the leftmost item has no left margin
,
Nov 9
Before (top) and after (bottom) with pending CL.
,
Nov 9
It looks like there's still a problem of padding, probably linked to the size of the asset containers. See comparison with the spec attached. It seems to me like they are not contained within their 20*20px containers.
,
Nov 10
Some more small bits and pieces. Attaching 1) current version, 2) what I get when removing all padding, 3) comparison with what Sebastien would expect with no padding. So I'm gonna start with reducing that difference before adding padding again.
,
Nov 10
Bounds of the battery icon.
,
Nov 10
I think the main differences are 1) the padding of the whole area, and 2) padding around the text "US"
,
Nov 10
With 8 instead of 5 as outside padding things match a lot better. Maybe it's better to specify that padding separately instead of making the text labels have padding on both sides that contribute to the outside padding.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35c5e6ff1248c790245768efed78235c32811d8e commit 35c5e6ff1248c790245768efed78235c32811d8e Author: Manu Cornet <manucornet@chromium.org> Date: Mon Nov 19 05:32:01 2018 CrOS sys tray: fix padding to better match spec A few changes here: * Specify padding on both ends of the whole tray separately (instead of using space around some tray items to build it up) * Override the size function for the battery to better match its actual visual footprint. * Specify padding between items with one single number, used at the layout level. This all allows for simpler code while better matching the specs. Bug: 901989 Change-Id: Ia75dcfc7b355b114e6492c26ee4ce6372af92f71 Reviewed-on: https://chromium-review.googlesource.com/c/1328042 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#609183} [modify] https://crrev.com/35c5e6ff1248c790245768efed78235c32811d8e/ash/system/date/date_view.cc [modify] https://crrev.com/35c5e6ff1248c790245768efed78235c32811d8e/ash/system/power/tray_power.cc [modify] https://crrev.com/35c5e6ff1248c790245768efed78235c32811d8e/ash/system/power/tray_power.h [modify] https://crrev.com/35c5e6ff1248c790245768efed78235c32811d8e/ash/system/tray/tray_constants.h [modify] https://crrev.com/35c5e6ff1248c790245768efed78235c32811d8e/ash/system/tray/tray_container.cc [modify] https://crrev.com/35c5e6ff1248c790245768efed78235c32811d8e/ash/system/tray/tray_item_view.cc [modify] https://crrev.com/35c5e6ff1248c790245768efed78235c32811d8e/ash/system/tray/tray_item_view.h
,
Nov 19
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sgabr...@chromium.org
, Nov 5