New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901987 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Reporting/NEL: Be more lenient when parsing policy headers

Project Member Reported by dcreager@chromium.org, Nov 5

Issue description

From https://github.com/w3c/network-error-logging/issues/85.

We want to be more lenient when parsing policy headers.  If you include a field in a policy header (e.g., a "success_fraction" in a NEL header), but the field's value has the wrong type, we currently ignore the entire policy header.  We could instead fall back on the default value, just as if the field were missing.
 
Owner: sburnett@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6320a166c34712372687f3cd6e35437e3c8ce643

commit 6320a166c34712372687f3cd6e35437e3c8ce643
Author: Sam Burnett <sburnett@chromium.org>
Date: Wed Nov 07 20:22:16 2018

Test that NEL ignores policy header fields when they're the wrong type.

Bug: 901987
Change-Id: Ic0f758b08afad0462deff8c7283ce1ab1a706dae
Reviewed-on: https://chromium-review.googlesource.com/c/1320595
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Douglas Creager <dcreager@chromium.org>
Commit-Queue: Sam Burnett <sburnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606146}
[modify] https://crrev.com/6320a166c34712372687f3cd6e35437e3c8ce643/net/network_error_logging/network_error_logging_service_unittest.cc

Sign in to add a comment