Define a cast.ApplicationConfig service API and provide a dummy implementation for testing/development |
|||
Issue descriptionCastRunner needs to be able to resolve a Cast app-Id to a set of properties, including the URL from which to load the Cast application. Define a chromium.cast.ApplicationConfig service API and provide an implementation suitable for testing & development, e.g: - Provide a "dummy" ApplicationConfig service implementation which serves a set of caller-supplied application configs. - Add e.g. browser-tests for CastRunner which pass it the dummy service. - Run those tests with an embedded web server which serves one or more test "Cast applications". - Test base can supply a hard-wired set of application configs, pointing to the embedded web server. - CastRunner itself could also check on startup whether there is an ApplicationConfig service available, and create one internally, with some hard-wired mappings, e.g. to standard web URLs, so we can at least verify that it launches correctly.
,
Dec 11
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e77541e469676bc18bcc90252f7dfea40fbb3fcc commit e77541e469676bc18bcc90252f7dfea40fbb3fcc Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Dec 13 18:50:24 2018 [Fuchsia] Add a chromium.cast.ApplicationConfigManager interface. This interface allows the Cast per-application configuration logic to be isolated from the application-hosting logic in the Runner. The current implementation of this interface is a stub in the app_config_manager service. In addition, this Cl adds a test-only implementation of this interface directing cast requests to an embedded test server. Bug: 901964 Change-Id: Ib635b3229eacab21bc4e307269a563ced26efc26 Reviewed-on: https://chromium-review.googlesource.com/c/1332713 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#616374} [modify] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/BUILD.gn [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/application_config_manager/application_config_manager.cc [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/application_config_manager/application_config_manager.h [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/application_config_manager/application_config_manager_unittest.cc [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/application_config_manager/main.cc [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/application_config_manager/sandbox_policy [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/application_config_manager/test/fake_application_config_manager.cc [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/application_config_manager/test/fake_application_config_manager.h [modify] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/cast_runner.cc [modify] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/cast_runner.h [modify] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/cast_runner_unittest.cc [modify] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/app/cast/main.cc [modify] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/cipd/castrunner.yaml [add] https://crrev.com/e77541e469676bc18bcc90252f7dfea40fbb3fcc/webrunner/fidl/cast/application_config.fidl
,
Dec 14
|
|||
►
Sign in to add a comment |
|||
Comment 1 by w...@chromium.org
, Nov 5