New issue
Advanced search Search tips

Issue 901955 link

Starred by 1 user
Status: Fixed
Owner:
fdegans@chromium.org
Closed: Dec 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug

Blocking:
issue 893229



Sign in to add a comment

Add some "browser tests" for CastRunner

Project Member Reported by w...@chromium.org, Nov 5 
We should provide some test coverage for the CastRunner, to verify that the Cast-specific stuff (e.g. API injection, Frame properties, etc) works as-intended.

We could implement this using the web.ContextProvider browser-test framework as a base, instantiating an in-process CastRunner alongside it. We'd need to refactor the CastRunner a little, to e.g. provide a way to instantiate it for test, without having it consume any of the host process' startup-handles.

Comment 1 by w...@chromium.org, Nov 5

Blocking: 893229
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/041a652ebd1154bcc855f5251a6513c2350da196

commit 041a652ebd1154bcc855f5251a6513c2350da196
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Dec 11 00:20:53 2018

[Fuchsia] Add package_deps for test targets.

This is necessary to provide true end-to-end testing of Fuchsia
packages as end users will use them.

Test: Locally, chromium.far is installed with castrunner_unittests.
Bug:  901955 
Change-Id: I9bb4f4fb17a5cb6b7a004209304fc6be992a2069
Reviewed-on: https://chromium-review.googlesource.com/c/1368990
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615344}
[modify] https://crrev.com/041a652ebd1154bcc855f5251a6513c2350da196/testing/test.gni
[modify] https://crrev.com/041a652ebd1154bcc855f5251a6513c2350da196/webrunner/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151e2fc98d9d2f435665143054927a512bb7dfc6

commit 151e2fc98d9d2f435665143054927a512bb7dfc6
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Wed Dec 19 20:05:28 2018

[Fuchsia] Add a CastRunner integration test.

CastRunnerTest.BasicRequest ensures that for a given cast URI, the
CastRunner and Chromium services are properly set up and start the right
URL.

Bug:  901955 
Change-Id: Ife7c788d201a0089cf866367c8181c35777ff484
Reviewed-on: https://chromium-review.googlesource.com/c/1379045
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617919}
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/build/config/fuchsia/testing_sandbox_policy
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/BUILD.gn
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/cast/cast_runner.cc
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/cast/cast_runner.h
[add] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/cast/cast_runner_integration_test.cc
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/cast/cast_runner_unittest.cc
[add] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/cast/test_common.cc
[add] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/cast/test_common.h
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/common/web_component.cc
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/common/web_component.h
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/common/web_content_runner.cc
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/app/common/web_content_runner.h
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/browser/frame_impl_browsertest.cc
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/common/named_message_port_connector_browsertest.cc
[modify] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/common/test/test_common.h
[add] https://crrev.com/151e2fc98d9d2f435665143054927a512bb7dfc6/webrunner/test/promise.h

Comment 4 by fdegans@chromium.org, Dec 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment