This bug is to track work related to implementing the "Search Ready Omnibox"; see https://crbug.com/894211.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5311426c4a73c3bd942040a35d4988d90a72b31c commit 5311426c4a73c3bd942040a35d4988d90a72b31c Author: Matthew Jones <mdjones@chromium.org> Date: Wed Dec 12 16:36:47 2018 Add flag for Search Ready Omnibox on Android Bug: 901952 Change-Id: I54bf2e5679b57d2780310272fbdf4d5defe06dcc Reviewed-on: https://chromium-review.googlesource.com/c/1366322 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#615923} [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/chrome/browser/about_flags.cc [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/chrome/browser/flag-metadata.json [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/chrome/browser/flag_descriptions.h [modify] https://crrev.com/5311426c4a73c3bd942040a35d4988d90a72b31c/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29ba1ac751a880e842de111d98314ae4beae2403 commit 29ba1ac751a880e842de111d98314ae4beae2403 Author: Matthew Jones <mdjones@chromium.org> Date: Wed Dec 12 17:40:56 2018 Move omnibox list adapter to modelutils/ and rename This patch turns the omnibox results adapter into a generic utility that can conceivably be used by any list represented by models. Since the view type returned by getView is not guaranteed to return a view of that type, we need a means of checking it. This patch adds a tag to views in that list that identify what type it is. This should allow lists that aren't necessarily recycler views to work correctly with heterogeneous lists. This patch also removes some unneeded property reset logic that was specific to omnibox suggestions. Bug: 901952 Change-Id: Ic4e51bd527849c9177eedc18389d7ff7f70cde84 Reviewed-on: https://chromium-review.googlesource.com/c/1366484 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615945} [modify] https://crrev.com/29ba1ac751a880e842de111d98314ae4beae2403/chrome/android/java/res/values/ids.xml [rename] https://crrev.com/29ba1ac751a880e842de111d98314ae4beae2403/chrome/android/java/src/org/chromium/chrome/browser/modelutil/ModelListAdapter.java [modify] https://crrev.com/29ba1ac751a880e842de111d98314ae4beae2403/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/29ba1ac751a880e842de111d98314ae4beae2403/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListViewBinder.java [modify] https://crrev.com/29ba1ac751a880e842de111d98314ae4beae2403/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c0cc38022792b21b938e562d12febe5933f4f2c commit 8c0cc38022792b21b938e562d12febe5933f4f2c Author: Matthew Jones <mdjones@chromium.org> Date: Thu Jan 10 20:51:34 2019 Implement edit url suggestion item for Search Ready Omnibox This patch is the main implementation for the edit URL suggestion item. Two variations are included: - Share + edit icon. - Copy + edit icon. The custom suggestion recycles the existing what-you-typed URL suggestion but replaces the view that is used. If the content in the omnibox changes, the suggestion changes back to the original suggestion item. The feature is currently disabled for incognito mode. Bug: 901952 Change-Id: Ic339479cca3818aec81abb66fc8069a02c2a628d Reviewed-on: https://chromium-review.googlesource.com/c/1372278 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#621736} [add] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/res/layout/edit_url_suggestion_layout.xml [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionUiType.java [add] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionCoordinator.java [add] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionProperties.java [add] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionViewBinder.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/CustomTabToolbar.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActionsNotificationManager.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/chrome/android/java_sources.gni [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/ui/android/java/src/org/chromium/ui/base/Clipboard.java [modify] https://crrev.com/8c0cc38022792b21b938e562d12febe5933f4f2c/ui/android/java/strings/android_ui_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77f0021e3e0b81eba2935bd148817d5824ab4a0d commit 77f0021e3e0b81eba2935bd148817d5824ab4a0d Author: Matthew Jones <mdjones@chromium.org> Date: Wed Jan 16 01:55:19 2019 Add general suggestion processor and migrate default suggestion This patch adds a new interface to generalize the task of processing new omnibox suggestions. Each implementor can specify a custom model for the suggestion to be rendered in a custom view. As proof of concept, the existing default omnibox suggestion has been migrated to its own package and implements the new interface. Bug:901952 Change-Id: I246ae64229ac6306f2a4a0bb38c46f5da637bd92 Reviewed-on: https://chromium-review.googlesource.com/c/1410011 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#623011} [modify] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java [modify] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionUiType.java [add] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionCommonProperties.java [rename] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/AnswerTextBuilder.java [add] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/BasicSuggestionProcessor.java [rename] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/SuggestionView.java [rename] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/SuggestionViewProperties.java [rename] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/SuggestionViewViewBinder.java [modify] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/java_sources.gni [modify] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java [modify] https://crrev.com/77f0021e3e0b81eba2935bd148817d5824ab4a0d/ui/android/java/src/org/chromium/ui/modelutil/PropertyModel.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25481bf950282063fb73d23533f97ad5021ffe68 commit 25481bf950282063fb73d23533f97ad5021ffe68 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Jan 17 19:03:03 2019 Hook up the Search Ready Omnibox feature This patch does all of the plumbing to hook up and use the classes for the Search Ready Omnibox. The EditUrlSuggestionCoordinator now implements the SuggestionProcessor interface and has been named to reflect that. The suggestion's view is now created on-demand as well. Bug: 901952 Change-Id: I7da177e73df0b1ab4e92d498efbd511cf1f863ad Reviewed-on: https://chromium-review.googlesource.com/c/1372720 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#623779} [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java [rename] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionProcessor.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionProperties.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionViewBinder.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/CustomTabToolbar.java [modify] https://crrev.com/25481bf950282063fb73d23533f97ad5021ffe68/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d23145226322b5e580477ae63c173d2beeae587b commit d23145226322b5e580477ae63c173d2beeae587b Author: Matthew Jones <mdjones@chromium.org> Date: Fri Jan 18 16:23:36 2019 Add histogram for action on first omnibox suggestion The added histogram is for the search-ready omnibox and includes: edit, copy, share, suggestion tap, and suggestion long-press. Bug: 881292,901952 Change-Id: Ia12d3cb11c048215bad43c8752aa3afae5b5b15a Reviewed-on: https://chromium-review.googlesource.com/c/1372560 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#624151} [modify] https://crrev.com/d23145226322b5e580477ae63c173d2beeae587b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionProcessor.java [modify] https://crrev.com/d23145226322b5e580477ae63c173d2beeae587b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/d23145226322b5e580477ae63c173d2beeae587b/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Dec 12