Add an autotest test that runs servo repair |
||
Issue descriptionThere's no good way to test changes to the servo repair process (e.g. https://crrev.com/c/129835). Current repair procedures try a lot of other ways of fixing the dut (e.g. rebooting it, power cycle with RPM, resetting via sysrq-x) before attempting to servo repair. It attempts a particular repair option only if it finds a corresponding trigger. Thus, calling repair on a healthy dut doesn't test the servo repair code path. It would be helpful to add a test that can force a reinstall from the the servo and run it on staging every once in a while to make sure that the changes to the servo repair code don't break it. For the list of potential repair options, search for "trigger" in the following log: https://storage.cloud.google.com/chromeos-autotest-results/hosts/chromeos2-row1-rack2-host1/104211-repair/debug/autoserv.DEBUG
,
Dec 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a2cdcf010c9012f9ac1400f39bb860724cec9759 commit a2cdcf010c9012f9ac1400f39bb860724cec9759 Author: Garry Wang <xianuowang@chromium.org> Date: Sat Dec 15 06:40:47 2018 autotest: add test force servo usb install repair Current repair procedures try a lot of other ways of fixing the dut before attempting to servo repair. It attempts a particular repair option only if it finds a corresponding trigger. Thus, calling repair on a healthy dut doesn't test the servo repair code path. This test will do the same steps as ServoInstallRepair been triggerred. BUG= chromium:901942 TEST=None Change-Id: I500ce1af2bd675e318ced2f79d2211666625d8d4 Reviewed-on: https://chromium-review.googlesource.com/1377551 Commit-Ready: Garry Wang <xianuowang@chromium.org> Tested-by: Garry Wang <xianuowang@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [add] https://crrev.com/a2cdcf010c9012f9ac1400f39bb860724cec9759/server/site_tests/servo_USBInstall/control [add] https://crrev.com/a2cdcf010c9012f9ac1400f39bb860724cec9759/server/site_tests/servo_USBInstall/servo_USBInstall.py
,
Jan 4
The test has been verified on staging autotest instance. |
||
►
Sign in to add a comment |
||
Comment 1 by akeshet@google.com
, Nov 5Owner: xianuowang@chromium.org
Status: Assigned (was: Untriaged)
Summary: Add an autotest test that runs servo repair (was: Add a way to force servo repair)