New issue
Advanced search Search tips

Issue 901933 link

Starred by 1 user
Status: Assigned
Owner:
l...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: support MHTML capture

Project Member Reported by l...@chromium.org, Nov 5 
To support DevTools Protocol clients who are interested in capturing MHTML, we can introduce an experimental method.

Blink's MHTML generator tries to capture such that the loaded archive looks as close as possible to the original.  Once this is added, we can explore new use cases.

https://docs.google.com/document/d/1zbviSYBMcY9E3CLwY_hihKih25D4JiwEvliS4xVzYFk/edit?usp=sharing
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c11f123579f47b7d61d8ec896b4004036974d6c

commit 8c11f123579f47b7d61d8ec896b4004036974d6c
Author: Erik Luo <luoe@chromium.org>
Date: Thu Nov 08 00:47:36 2018

[inspector] introduce MHTML capture over protocol

Adds new experimental protocol method, which uses
`WebContents::GenerateMHTML` underneath.

Bug: 901933
Change-Id: I52e707f89378fe3a1488a3cd8afd7cdded1b77ea
Reviewed-on: https://chromium-review.googlesource.com/c/1297732
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606256}
[modify] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/content/browser/BUILD.gn
[add] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/content/browser/devtools/protocol/devtools_mhtml_helper.cc
[add] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/content/browser/devtools/protocol/devtools_mhtml_helper.h
[modify] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/content/browser/devtools/protocol_config.json
[add] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/third_party/WebKit/LayoutTests/inspector-protocol/page/capture-snapshot-expected.txt
[add] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/third_party/WebKit/LayoutTests/inspector-protocol/page/capture-snapshot.js
[modify] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/8c11f123579f47b7d61d8ec896b4004036974d6c/third_party/blink/renderer/core/inspector/inspector_protocol_config.json
►

Sign in to add a comment