New issue
Advanced search Search tips

Issue 901928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Allow device model (from given board family) to be added to suite_scheduler for scheduling tests

Project Member Reported by harpreet@chromium.org, Nov 5

Issue description

"boards / exclude_boards" entry in suite_scheduler allows you to add / exclude boards that the tests should be scheduled on. This does not work as intended for new boards which follow board / model concept. For eg. if I only want to run tests on astronaut which is a coral board, current there is not way to do this. I will have to add 'coral' board which will end up scheduling tests on every coral model when I only want a specific model like astronaut.

model_list is used to maintain the list of all devices within given board family. We should utilize this to allow for model level inclusion / exclusion in suite_scheduler.
https://cs.corp.google.com/chromeos_public/infra/suite_scheduler/configs/lab_config.ini?l=487 
 
Cc: xixuan@chromium.org
Cc: -xixuan@chromium.org dtosic@google.com xix...@chromium.orgm
Status: Available (was: Untriaged)
Cc: chromeos-test-team@google.com
Labels: -Pri-2 Pri-1
Cc: -xix...@chromium.orgm xixuan@chromium.org
Owner: xixuan@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/suite_scheduler/+/89897180c1a8fb54d5df685b6c1441cdbf51a776

commit 89897180c1a8fb54d5df685b6c1441cdbf51a776
Author: Xixuan Wu <xixuan@google.com>
Date: Tue Jan 08 03:40:30 2019

suite-scheduler: Add config entry models & exclude_models.

BUG= chromium:901928 
TEST=None

Change-Id: Ia54c21fa0e9af7d018636a0d14a74aca7d2cbb8b
Reviewed-on: https://chromium-review.googlesource.com/1395237
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/89897180c1a8fb54d5df685b6c1441cdbf51a776/config_reader.py
[modify] https://crrev.com/89897180c1a8fb54d5df685b6c1441cdbf51a776/task.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/suite_scheduler/+/3b9dfb42def2b13f0b02d5ec08b9ce9f1c5bce3a

commit 3b9dfb42def2b13f0b02d5ec08b9ce9f1c5bce3a
Author: Xixuan Wu <xixuan@google.com>
Date: Tue Jan 08 03:40:30 2019

suite-scheduler: support config entry models & exclude_models.

BUG= chromium:901928 
TEST=Ran unittest.

Change-Id: I71ebfc290a3c67e081eb71abb12cfd9bd231be0c
Reviewed-on: https://chromium-review.googlesource.com/1395941
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/3b9dfb42def2b13f0b02d5ec08b9ce9f1c5bce3a/trigger_receiver_unittest.py
[modify] https://crrev.com/3b9dfb42def2b13f0b02d5ec08b9ce9f1c5bce3a/task.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/suite_scheduler/+/588668d46b49fe34644ac70749a8d50dca6bf413

commit 588668d46b49fe34644ac70749a8d50dca6bf413
Author: Xixuan Wu <xixuan@google.com>
Date: Tue Jan 08 03:40:30 2019

suite-scheduler: Unify full_model's parsing and formation.

BUG= chromium:901928 
TEST=Ran unittest.

Change-Id: I9c6ccbb8ad58e30b38b370272132f631f5547e84
Reviewed-on: https://chromium-review.googlesource.com/1395942
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/588668d46b49fe34644ac70749a8d50dca6bf413/config_reader.py
[modify] https://crrev.com/588668d46b49fe34644ac70749a8d50dca6bf413/task.py
[modify] https://crrev.com/588668d46b49fe34644ac70749a8d50dca6bf413/build_lib.py

Status: Fixed (was: Started)

Sign in to add a comment