New issue
Advanced search Search tips

Issue 901909 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 7
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Reject updateUI call if Background Fetch event is out of scope

Project Member Reported by rayankans@chromium.org, Nov 5 
The spec specifies the cases in which the event should be rejected:
https://wicg.github.io/background-fetch/#background-fetch-update-ui-event
6.7.1.1
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88878f4f5fc03ecc9d010662603265d9523972f7

commit 88878f4f5fc03ecc9d010662603265d9523972f7
Author: Rayan Kanso <rayankans@google.com>
Date: Wed Nov 07 19:20:40 2018

[Background Fetch] Reject call to updateUI if event is inactive.

Spec:
https://wicg.github.io/background-fetch/#background-fetch-update-ui-event-update-ui

Bug:  901909 
Change-Id: Ia319cd03e41e65c5a6a1f5e61cde6f4ae7705a32
Reviewed-on: https://chromium-review.googlesource.com/c/1320330
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606118}
[modify] https://crrev.com/88878f4f5fc03ecc9d010662603265d9523972f7/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/88878f4f5fc03ecc9d010662603265d9523972f7/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw-update-ui.js
[modify] https://crrev.com/88878f4f5fc03ecc9d010662603265d9523972f7/third_party/WebKit/LayoutTests/external/wpt/background-fetch/update-ui.https.window.js
[modify] https://crrev.com/88878f4f5fc03ecc9d010662603265d9523972f7/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.cc
[modify] https://crrev.com/88878f4f5fc03ecc9d010662603265d9523972f7/third_party/blink/renderer/modules/service_worker/wait_until_observer.cc
[modify] https://crrev.com/88878f4f5fc03ecc9d010662603265d9523972f7/third_party/blink/renderer/modules/service_worker/wait_until_observer.h

Comment 2 by rayankans@chromium.org, Nov 7

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dc62a57f06c50d8c8f0bba7ef385936766fdbca

commit 5dc62a57f06c50d8c8f0bba7ef385936766fdbca
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Nov 08 05:57:27 2018

service worker: Re-add early return that was accidentally removed

It was accidentally removed in r606118.

Bug:  901909 
Change-Id: I8a3e96b6ed2acc1aac7f71b9de30206771cb8ad1
Reviewed-on: https://chromium-review.googlesource.com/c/1325591
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606362}
[modify] https://crrev.com/5dc62a57f06c50d8c8f0bba7ef385936766fdbca/third_party/blink/renderer/modules/service_worker/wait_until_observer.cc
►

Sign in to add a comment