Make it more clear when discrepancies are found |
||
Issue descriptionThere are various classes of discrepancies that Milo knows about, such as: * All steps are complete, but the build isn't (crbug.com/901718) * Build is complete, but steps aren't * Build is found, but annotations are missing from logdog Make it more clear in Milo that this is an infra issue, not a build issue.
,
Nov 5
There (may?) still be an UI issue if the swarming task continues to run (Thereby keeping buildbucket in a "running" state), but all steps are "complete" (Since steps are sourced from Kitchen/Recipe). It might not be a Milo issue, but can be still a source of inconsistency.
,
Nov 5
what would milo do in this case? something like "this build if wrapping up some internal stuff"?
,
Nov 5
There are various options that can be explored:
1. Milo or Buildbucket detects this and adds a magic step
2. Milo or Buildbucket detects this and changes the status to a magic status ("Running - Swarming cleanup")
3. Milo or Buildbucket detects this and adds an out-of-band message (ie butterbar)
In terms of user expectation, I think #1 makes sense, since as far as the user is concerned "something" in the infrastructure is happening, and "something" generally maps to steps.
,
Nov 15
since this is a UI-level problem, the solution should also be UI-level, which is Milo, not buildbucket. I am prefer no magic. If we present this as a legit step, a user may expect to find it in other places, e.g. buildbucket RPC response or BigQuery. It wouldn't be there. We can render something below steps, but not pretending it is a step.
,
Jan 17
(5 days ago)
With a test-centric Milo and data from buildbucket, this isn't super important anymore. |
||
►
Sign in to add a comment |
||
Comment 1 by no...@chromium.org
, Nov 5