New issue
Advanced search Search tips

Issue 901892 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Make it more clear when discrepancies are found

Project Member Reported by hinoka@chromium.org, Nov 5

Issue description

There are various classes of discrepancies that Milo knows about, such as:

* All steps are complete, but the build isn't (crbug.com/901718)
* Build is complete, but steps aren't
* Build is found, but annotations are missing from logdog

Make it more clear in Milo that this is an infra issue, not a build issue.
 
Note that the cause of discrepancies is Milo loading steps from a side channel (LogDog). This wouldn’t be a problem if Milo loaded steps from buildbucket: bug 850113
There (may?) still be an UI issue if the swarming task continues to run (Thereby keeping buildbucket in a "running" state), but all steps are "complete" (Since steps are sourced from Kitchen/Recipe).  It might not be a Milo issue, but can be still a source of inconsistency.
what would milo do in this case? something like "this build if wrapping up some internal stuff"?
There are various options that can be explored:

1. Milo or Buildbucket detects this and adds a magic step
2. Milo or Buildbucket detects this and changes the status to a magic status ("Running - Swarming cleanup")
3. Milo or Buildbucket detects this and adds an out-of-band message (ie butterbar)

In terms of user expectation, I think #1 makes sense, since as far as the user is concerned "something" in the infrastructure is happening, and "something" generally maps to steps.
since this is a UI-level problem, the solution should also be UI-level, which is Milo, not buildbucket.
I am prefer no magic. If we present this as a legit step, a user may expect to find it in other places, e.g. buildbucket RPC response or BigQuery. It wouldn't be there. We can render something below steps, but not pretending it is a step.

Comment 6 by hinoka@chromium.org, Jan 17 (5 days ago)

Status: WontFix (was: Unconfirmed)
With a test-centric Milo and data from buildbucket, this isn't super important anymore.

Sign in to add a comment