Form resubmission popover is not aligned to the omnibox |
|||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Submit a html form (2) Reload the page What is the expected result? The form resubmission alert should be displayed. What happens instead? The form resubmission alert is correctly displayed but in a popover, which looks weird. It looks like we are displaying it, it is not a WKWebView feature. Not sure who to assign it to.
,
Nov 5
,
Nov 5
Tested on iPad Pro 12'9 iOS 11.4.1 BAD Version: 72.0.3592.0 (Official Build) canary (64-bit) Revision : 3274d2b27158c8f54008ac69629235202f28f306-refs/branch-heads/3592@{#1} GOOD Version : 72.0.3591.0 (Official Build) canary (64-bit) Revision : 148434e1b31c81381aec3e1346c9bf7954de39d6-refs/branch-heads/3591@{#1}
,
Nov 6
My test was the EG test in FormsTestCase.
,
Nov 6
@Gambard: Could you please provide sample file or URL that reproduces the issue so that it would be really helpful for triaging of the issue. Thanks.!
,
Nov 6
Adding to comment#5. @Gambard: Could you please confirm if the issue is specific to iOS and also request you to provide the reported chrome version.
,
Nov 6
I think it is only related to iOS sorry. I forgot to set the OS bit. I found it on 72.0.3604.0.
,
Nov 6
(And I don't have specific URL, this is part of our automated integration test.)
,
Nov 6
Bisect complete in comment#3. To repro the case please use the test URL https://rsolomakhin.github.io/autofill/
,
Nov 7
stkhapugin@ could you PTAL?
,
Nov 12
I don't think I'm the right owner for this.
,
Nov 13
Is this iPad only or iPhone too? Not sure if this is actually in michaeldo's area, but I'm starting there. Let's see if we know why it is recently broken (see comment 3) and then decide if RBS is appropriate.
,
Nov 14
The issue is that the popover is misaligned, not how it is displayed. It should appear to be coming from the omnibox. (This was the "Good" behavior as of 72.0.3591.0) Note that when I repo, the arrow on the popover is pointed up. I'm not sure why it is pointed to the right in the screenshot in #c0. I looked into this and it is caused by kBrowserContainerFullscreen being enabled by default between the good and bad revisions. Assigning to kkhorimoto@ for further investigation.
,
Dec 14
,
Dec 14
,
Dec 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/200f5afd7830708aa30a2e16db540e5f146c7b5b commit 200f5afd7830708aa30a2e16db540e5f146c7b5b Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Sat Dec 22 04:33:22 2018 [iOS] Fix layout of form resubmission dialog. This CL updates the dialog location to be calculated in the BVC's coordinate space and updates RepostFormCoordinator to use its baseViewController's view for the coordinate space. Bug: 901885 Change-Id: I9856dc041cc49a78d7f916e6662bf838d0ac5f44 Reviewed-on: https://chromium-review.googlesource.com/c/1379036 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#618729} [modify] https://crrev.com/200f5afd7830708aa30a2e16db540e5f146c7b5b/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator.h [modify] https://crrev.com/200f5afd7830708aa30a2e16db540e5f146c7b5b/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator.mm [modify] https://crrev.com/200f5afd7830708aa30a2e16db540e5f146c7b5b/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator_unittest.mm [modify] https://crrev.com/200f5afd7830708aa30a2e16db540e5f146c7b5b/ios/chrome/browser/ui/browser_view_controller.mm
,
Dec 26
,
Dec 26
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3
Canary verification please.
,
Jan 7
Verified in canary using https://rsolomakhin.github.io/autofill/, popover is placed correctly at the omnibox.
,
Jan 8
,
Jan 11
Approved, please merge asap.
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac Commit: 74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac Author: kkhorimoto@chromium.org Commiter: kkhorimoto@chromium.org Date: 2019-01-11 18:09:59 +0000 UTC [iOS] Fix layout of form resubmission dialog. This CL updates the dialog location to be calculated in the BVC's coordinate space and updates RepostFormCoordinator to use its baseViewController's view for the coordinate space. Bug: 901885 Change-Id: I9856dc041cc49a78d7f916e6662bf838d0ac5f44 Reviewed-on: https://chromium-review.googlesource.com/c/1379036 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618729}(cherry picked from commit 200f5afd7830708aa30a2e16db540e5f146c7b5b) Reviewed-on: https://chromium-review.googlesource.com/c/1407126 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#644} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac commit 74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Jan 11 18:09:59 2019 [iOS] Fix layout of form resubmission dialog. This CL updates the dialog location to be calculated in the BVC's coordinate space and updates RepostFormCoordinator to use its baseViewController's view for the coordinate space. Bug: 901885 Change-Id: I9856dc041cc49a78d7f916e6662bf838d0ac5f44 Reviewed-on: https://chromium-review.googlesource.com/c/1379036 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618729}(cherry picked from commit 200f5afd7830708aa30a2e16db540e5f146c7b5b) Reviewed-on: https://chromium-review.googlesource.com/c/1407126 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#644} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator.h [modify] https://crrev.com/74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator.mm [modify] https://crrev.com/74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator_unittest.mm [modify] https://crrev.com/74bf8cdf9e3cd323e9a6a37a79d555b6c027f1ac/ios/chrome/browser/ui/browser_view_controller.mm
,
Today
(100 minutes ago)
Unable to repro the issue in latest M72 beta Build Version: 72.0.3626.70 beta Devices: iPad Air(12.1.3) Screenshot: https://drive.google.com/open?id=1jVD-oJimfl5pI3PvwX6NpeiE36u-qZ3R |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by eugene...@chromium.org
, Nov 5Components: -Mobile>iOSWeb>PageLoad UI>Browser>Core
Labels: Needs-Bisect