New issue
Advanced search Search tips

Issue 901884 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

memd ignores OOM kill notification

Project Member Reported by semenzato@chromium.org, Nov 5

Issue description

Memd was not listening to OOM kill notifications from anomaly_collector.  It does now following https://crrev.com/c/1318189, which needs to go into R71 as well.

 
Sorry, the original CL is here: https://crrev.com/c/1308673
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 5

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
A few comment on risks.  The CL makes memd receive an additional D-Bus message.  This message has the same protobuf of an existing message, and upon receiving the new message, it exercises no new code i.e. it uses existing code paths with different enum and string values.  Thus I do not foresee any unexpected side effects.

The code has been exercised by a new autotest (tast-test) at https://crrev.com/c/1306913, and has been on ToT for a few days.  I haven't pushed the memd tast-test yet because it will fail without these changes.
Status: Started (was: Untriaged)
Labels: -Merge-Review-71 Merge-Approved-71
Merge approved for ChromeOS M71
Thanks!
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 5

Labels: merge-merged-release-R71-11151.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8cb1cd62572009851b84217eefc273e4ad006d39

commit 8cb1cd62572009851b84217eefc273e4ad006d39
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Mon Nov 05 18:35:09 2018

metrics: memd: handle signals from anomaly_collector

The anomaly_collector daemon produces D-Bus signals when
it detects kernel OOM-kills from parsing the syslog.
Memd needs to receive these signals.

BUG= chromium:901884 
TEST=unit tests, plus memd tast-test (to be merged soon)

Change-Id: Ie51dd48fafebc25ed14286bac1609125c71b0d8f
Reviewed-on: https://chromium-review.googlesource.com/1308673
Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
(cherry picked from commit a2b81d41917f67a21b9ff3b0f07561f60516c591)
Reviewed-on: https://chromium-review.googlesource.com/c/1318189
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Commit-Queue: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/8cb1cd62572009851b84217eefc273e4ad006d39/metrics/memd/src/test.rs
[modify] https://crrev.com/8cb1cd62572009851b84217eefc273e4ad006d39/metrics/memd/src/main.rs

Project Member

Comment 8 by sheriffbot@chromium.org, Nov 9

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-71 Merge-Merged
Status: Fixed (was: Started)

Sign in to add a comment