Improve v2 viz hit testing |
||||||
Issue descriptionDespite the finch of v2, we can still see around 5% hit testing instances fall into slow path. We need to investigate and improve the performance. ⛆ |
|
|
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/813e1d54d7f7bba3d4960be1b38b7d37fe81381e commit 813e1d54d7f7bba3d4960be1b38b7d37fe81381e Author: Xianda Sun <sunxd@chromium.org> Date: Mon Nov 19 21:49:57 2018 Fix async hit test reasons metric bug This patch fixes a bug that we early return in HitTestQuery at the presence of kHitTestAsk flag but do not collect asking reasons. Bug: 901882 Change-Id: Iebc677d9ce9ef7ea739e06a2844c49796ed84a27 Reviewed-on: https://chromium-review.googlesource.com/c/1342048 Reviewed-by: Ria Jiang <riajiang@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609454} [modify] https://crrev.com/813e1d54d7f7bba3d4960be1b38b7d37fe81381e/components/viz/host/hit_test/hit_test_query.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e7fdf11ecb0fe2c64f9af9fd77c3c2124675b18 commit 2e7fdf11ecb0fe2c64f9af9fd77c3c2124675b18 Author: Xianda Sun <sunxd@chromium.org> Date: Wed Nov 28 17:40:04 2018 Use layer tree to generate data when VizHitTestSurfaceLayer is enabled We previously use other hit test data providers whenever there is one created, regardless of whether we enable VizHitTestSurfaceLayer or not. This makes the flag no longer effective in some conditions as we can create a draw quad hit test data provider arbitrarily sometimes. It accounts for the async hit testing of approximately 1% of all hit testing requests when VizHitTestSurfaceLayer is enabled. This patch makes us use layer tree hit test data when the flag is enabled. Bug: 901882 Change-Id: I833b693368721b09e1d2922274d21170a24125d7 Reviewed-on: https://chromium-review.googlesource.com/c/1348949 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611757} [modify] https://crrev.com/2e7fdf11ecb0fe2c64f9af9fd77c3c2124675b18/cc/mojo_embedder/async_layer_tree_frame_sink.cc [modify] https://crrev.com/2e7fdf11ecb0fe2c64f9af9fd77c3c2124675b18/ui/aura/local/window_port_local.cc [modify] https://crrev.com/2e7fdf11ecb0fe2c64f9af9fd77c3c2124675b18/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/2e7fdf11ecb0fe2c64f9af9fd77c3c2124675b18/ui/compositor/host/host_context_factory_private.cc
,
Dec 11
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8b6d56285606a3c20bd158a48739249e289c04d commit b8b6d56285606a3c20bd158a48739249e289c04d Author: Xianda Sun <sunxd@chromium.org> Date: Fri Dec 14 23:54:57 2018 Enable v2 hit testing with VizDisplayCompositor This patch enables V2 viz hit testing (OOPIF hit testing with cc data) with VizDisplayCompositor. Bug: 901882 Change-Id: If8fc1483303e6081e985d02249de9e75959f4420 Reviewed-on: https://chromium-review.googlesource.com/c/1370464 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#616881} [modify] https://crrev.com/b8b6d56285606a3c20bd158a48739249e289c04d/components/viz/common/features.cc
,
Today
(10 hours ago)
|
|||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Nov 14