New issue
Advanced search Search tips

Issue 901879 link

Starred by 1 user
Status: Verified
Owner:
boliu@chromium.org
Closed: Nov 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Merge request for webview rendering issue in gmail

Project Member Reported by boliu@chromium.org, Nov 5 
Internal bug b/117560442

Requesting merging https://chromium-review.googlesource.com/c/1295315. The actual fix is changing a false to true. The rest is tests.

It's a pretty safe change change that only affects this edge case. The bug has been there for awhile so it's not a recent regression, but merging to m71 would better line up with gmail schedule so they don't have submit a workaround on their end.
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 5

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by benmason@chromium.org, Nov 5

Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Approved for merge to 71, branch 3578.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 5

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87531af63e5f913041462767bc5b3a5e3be04279

commit 87531af63e5f913041462767bc5b3a5e3be04279
Author: Bo Liu <boliu@chromium.org>
Date: Mon Nov 05 19:58:46 2018

[Merge M71] aw: Default surface_rect_empty to true

The default for an "is empty" value should be true to better match
reality. This is breaking the case where an offscreen webview is
directly translated on-screen without another onDraw recording on the UI
thread. The comparison in BVR::OnParentDrawConstraintsUpdated is
supposed to catch this case and cause another invalidate.

This CL refers to internal bug b/117560442

Change-Id: Ic03f91631780a2057931cb39cdecd04d32f52b1d
Reviewed-on: https://chromium-review.googlesource.com/c/1295315
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604297}
(cherry picked from commit 6b65b358f07a7d16ee340189968f38f1c3bc320e)

Bug:  901879 
Change-Id: Ia19c3451e1fd003a79417489d8c117f139d22926
Reviewed-on: https://chromium-review.googlesource.com/c/1318407
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#512}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/87531af63e5f913041462767bc5b3a5e3be04279/android_webview/browser/browser_view_renderer_unittest.cc
[modify] https://crrev.com/87531af63e5f913041462767bc5b3a5e3be04279/android_webview/browser/parent_compositor_draw_constraints.cc
[modify] https://crrev.com/87531af63e5f913041462767bc5b3a5e3be04279/android_webview/browser/test/fake_window.h
Project Member

Comment 4 by cr-audit...@appspot.gserviceaccount.com, Nov 5

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/87531af63e5f913041462767bc5b3a5e3be04279

Commit: 87531af63e5f913041462767bc5b3a5e3be04279
Author: boliu@chromium.org
Commiter: boliu@chromium.org
Date: 2018-11-05 19:58:46 +0000 UTC

[Merge M71] aw: Default surface_rect_empty to true

The default for an "is empty" value should be true to better match
reality. This is breaking the case where an offscreen webview is
directly translated on-screen without another onDraw recording on the UI
thread. The comparison in BVR::OnParentDrawConstraintsUpdated is
supposed to catch this case and cause another invalidate.

This CL refers to internal bug b/117560442

Change-Id: Ic03f91631780a2057931cb39cdecd04d32f52b1d
Reviewed-on: https://chromium-review.googlesource.com/c/1295315
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604297}
(cherry picked from commit 6b65b358f07a7d16ee340189968f38f1c3bc320e)

Bug:  901879 
Change-Id: Ia19c3451e1fd003a79417489d8c117f139d22926
Reviewed-on: https://chromium-review.googlesource.com/c/1318407
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#512}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 5 by boliu@chromium.org, Nov 5

Status: Verified (was: Assigned)
►

Sign in to add a comment