New issue
Advanced search Search tips

Issue 901867 link

Starred by 1 user
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[hrefTranslate] Don't add target to Accept-Languages

Project Member Reported by anthonyvd@chromium.org, Nov 5 
Translations generally add the target language to the Accept-Languages list. This shouldn't be the case for hrefTranslate-initiated translations, as those aren't necessarily a signal that the user understands the language.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7d4efe96104bb5f174477b85228520559fc298

commit de7d4efe96104bb5f174477b85228520559fc298
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Wed Nov 28 20:34:07 2018

Avoid adding hrefTranslate targets to accept languages

Bug:  901867 
Change-Id: Ica4f7ef18854c726f678485ce045042b8d13fbc1
Reviewed-on: https://chromium-review.googlesource.com/c/1352334
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611854}
[modify] https://crrev.com/de7d4efe96104bb5f174477b85228520559fc298/chrome/browser/translate/translate_manager_browsertest.cc
[modify] https://crrev.com/de7d4efe96104bb5f174477b85228520559fc298/chrome/test/data/href_translate_test.html
[modify] https://crrev.com/de7d4efe96104bb5f174477b85228520559fc298/components/translate/core/browser/translate_manager.cc

Comment 2 by anthonyvd@chromium.org, Dec 3

Status: Fixed (was: Assigned)
►

Sign in to add a comment