Issue 901864 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	anthonyvd@chromium.org
Closed:	Dec 3
Components:	UI>Browser>Language>Translate
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

[hrefTranslate] Validate target language before triggering translation

Project Member Reported by anthonyvd@chromium.org, Nov 5

Issue description

The value of hrefTranslate should be validated to be a supported language before triggering translation. This will prevent unpredictable fallback behavior from the Translate Element script.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/163dcc7f848fe4ad76a4760ff9d29392225e1279

commit 163dcc7f848fe4ad76a4760ff9d29392225e1279
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Nov 27 17:26:11 2018

Only trigger hrefTranslate if language is supported

Bug:  901864 
Change-Id: I5d86a6017d4d3fd45169af7daf58899158d7a1a7
Reviewed-on: https://chromium-review.googlesource.com/c/1351384
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611163}
[modify] https://crrev.com/163dcc7f848fe4ad76a4760ff9d29392225e1279/chrome/browser/translate/translate_manager_browsertest.cc
[modify] https://crrev.com/163dcc7f848fe4ad76a4760ff9d29392225e1279/chrome/test/data/href_translate_test.html
[modify] https://crrev.com/163dcc7f848fe4ad76a4760ff9d29392225e1279/components/translate/content/browser/content_translate_driver.cc

Comment 2 by anthonyvd@chromium.org, Dec 3

Status: Fixed (was: Assigned)

►

Issue 901864 link

Issue metadata

[hrefTranslate] Validate target language before triggering translation

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 27

Comment 1 Deleted

Comment 2 by anthonyvd@chromium.org, Dec 3

Comment 2 Deleted

Sign in to add a comment