New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment
link

Issue 901859: Split //components/signin/core/browser GN target into internals, shared, and client-side targets

Reported by blundell@chromium.org, Nov 5 Project Member

Issue description

//components/signin/core/browser contains three different types of code:

1. Code that forms the guts of IdentityManager and will form the guts of the Identity Service implementation (e.g., SigninManager).

2. Code that will be clients of IdentityManager (e.g., SigninTracker).

3. Code that will be used on both sides (e.g., AccountInfo).

Currently, all of these are naturally grouped in the same GN target, since there was never any distinction between them. However, we need to separate them in GN now to enable converting the code in 2 to use IdentityManager. This split will also define the scope of the conversion of the codebase to IdentityManager: everything that is in 1 will need to have its clients converted to use IdentityManager.
 

Comment 1 by blundell@chromium.org, Nov 6

Blocking: 893133

Comment 2 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc2c5126634d0574fe02ec7c839e6dd2f07432ed

commit dc2c5126634d0574fe02ec7c839e6dd2f07432ed
Author: Colin Blundell <blundell@chromium.org>
Date: Tue Nov 06 14:37:38 2018

Create initial split of //components/signin into internals/externals

//components/signin/core/browser contains three different types of code:

1. Code that forms the guts of IdentityManager and will form the guts of
the Identity Service implementation (e.g., SigninManager).

2. Code that will be clients of IdentityManager (e.g., SigninTracker).

3. Code that will be used on both sides (e.g., AccountInfo).

Currently, all of these are naturally grouped in the same GN target,
since there was never any distinction between them. However, we need to
separate them in GN now to enable converting the code in 2 to use
IdentityManager. This split will also define the scope of the conversion
of the codebase to IdentityManager: everything that is in 1 will need to
have its clients converted to use IdentityManager.

This CL performs an initial split, via the following process:

- Moved signin_manager(_base).*, profile_oauth2_token_service.*, and
  account_tracker_service.* into a new "internals" target that the
  existing target now depends on.
- Kept moving in code (and adding dependencies as needed) until
  "gn check" no longer complained about the "internals" target including
  code that wasn't in any dependencies.

This CL also modifies //services/identity/public/cpp to depend only on
//components/signin/core/browser:internals; this change is is the
concrete benefit from doing the split, as it is what will allow us to
convert client code in //components/signin/core/browser.

Future CLs will refine the split, but this is a good initial checkpoint.

Bug:  901859 
Change-Id: Ied46c4cdf0153b78b53516fec9537a83c4c0a71d
Reviewed-on: https://chromium-review.googlesource.com/c/1317915
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605671}
[modify] https://crrev.com/dc2c5126634d0574fe02ec7c839e6dd2f07432ed/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/dc2c5126634d0574fe02ec7c839e6dd2f07432ed/services/identity/public/cpp/BUILD.gn

Comment 3 by bugdroid1@chromium.org, Nov 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecee78d84dcd7148d7430ee502ebd1ef93f49e99

commit ecee78d84dcd7148d7430ee502ebd1ef93f49e99
Author: Colin Blundell <blundell@chromium.org>
Date: Wed Nov 07 10:02:30 2018

Remove unneeded include from test_signin_client.cc

This include causes complications when splitting
//components/signin/core/browser:test_support into "internals"
and "externals" targets: test_signin_client.h will go into the
"internals" target, which should not depend on
//components/signin/core/browser, which the included file is part of.

Happily, this include isn't used and can be removed :).

Bug:  901859 
Change-Id: Ia9cd8381773801932af31856e45f9aa2a54b38c5
Reviewed-on: https://chromium-review.googlesource.com/c/1319590
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606006}
[modify] https://crrev.com/ecee78d84dcd7148d7430ee502ebd1ef93f49e99/components/signin/core/browser/test_signin_client.cc

Comment 4 by bugdroid1@chromium.org, Nov 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdd0e27403ca49b3fc2d6053ce3447aec4868aa0

commit cdd0e27403ca49b3fc2d6053ce3447aec4868aa0
Author: Colin Blundell <blundell@chromium.org>
Date: Wed Nov 07 15:21:57 2018

Create initial split of //components/signin test_support target

//components/signin/core/browser contains three different types of code:

1. Code that forms the guts of IdentityManager and will form the guts of
the Identity Service implementation (e.g., SigninManager).

2. Code that will be clients of IdentityManager (e.g., SigninTracker).

3. Code that will be used on both sides (e.g., AccountInfo).

Currently, the test support for all of these is naturally grouped in the
same GN target, since there was never any distinction between them.
However, we need to separate this test support in GN now, as the test
support for IdentityManager should depend only on 1 and 3 (and their
associated test support).

This CL performs an initial split, via the following process:

- Moved fake_signin_manager.*, fake_profile_oauth2_token_service.*, and
  fake_gaia_cookie_manager_service.* into a new "test_support_internals"
  target that the existing target now depends on.
- Kept moving in code (and adding dependencies as needed) until
  "gn check" no longer complained about the "test_support_internals"
  target including code that wasn't in any dependencies.

This CL also modifies //services/identity/public/cpp:test_support to
depend only on //components/signin/core/browser:internals_test_support;
this change is is the concrete benefit from doing the split.

Finally, this CL strips both the test_support_internals and the
test_support target down to the dependencies that they actually need;
this change necessitated added some missing direct dependencies to
other targets.

Bug:  901859 
Change-Id: I0ac61f69c0c897d97b570c16d06f0e4f5f99d037
Reviewed-on: https://chromium-review.googlesource.com/c/1319669
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606046}
[modify] https://crrev.com/cdd0e27403ca49b3fc2d6053ce3447aec4868aa0/components/browser_sync/BUILD.gn
[modify] https://crrev.com/cdd0e27403ca49b3fc2d6053ce3447aec4868aa0/components/invalidation/impl/BUILD.gn
[modify] https://crrev.com/cdd0e27403ca49b3fc2d6053ce3447aec4868aa0/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/cdd0e27403ca49b3fc2d6053ce3447aec4868aa0/services/identity/BUILD.gn
[modify] https://crrev.com/cdd0e27403ca49b3fc2d6053ce3447aec4868aa0/services/identity/public/cpp/BUILD.gn

Comment 5 by bugdroid1@chromium.org, Nov 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac55c997637a8092ceb6410367b220841b749d11

commit ac55c997637a8092ceb6410367b220841b749d11
Author: Colin Blundell <blundell@chromium.org>
Date: Wed Nov 07 15:30:33 2018

Rename profile_management_switches.* to account_consistency_method.*

As suggested by msarda@ on
https://chromium-review.googlesource.com/c/chromium/src/+/1317915.

TBR=jochen@chromium.org

Bug:  901859 
Change-Id: I4b317bafa5e4a1a017e1977e2ddd444c61c3cfd3
Reviewed-on: https://chromium-review.googlesource.com/c/1319596
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606049}
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/android/signin/signin_manager_android.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/printing/print_dialog_cloud.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/avatar_menu.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/gaia_info_update_service.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/host_zoom_map_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_info_cache_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_list_desktop.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_list_desktop_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/profiles/profile_window_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/account_consistency_mode_manager.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/account_consistency_mode_manager_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/account_reconcilor_factory.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/chrome_signin_client_factory.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/chrome_signin_client_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/chrome_signin_helper.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/chrome_signin_helper_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/dice_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/dice_response_handler.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/dice_tab_helper.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/process_dice_header_delegate_impl.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/scoped_account_consistency.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/signin_error_controller_factory.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/signin_global_error.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/signin_promo.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/signin_tracker_factory.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/signin_ui_util.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/signin/signin_ui_util_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/browser_command_controller_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/browser_command_controller_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/signin_view_controller.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/signin/inline_login_ui.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/signin/login_ui_service.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/chrome/browser/ui/zoom/zoom_controller_browsertest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/BUILD.gn
[rename] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/account_consistency_method.cc
[rename] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/account_consistency_method.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/chrome_connected_header_helper.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/dice_account_reconcilor_delegate.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/dice_header_helper.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/signin_client.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/signin_header_helper.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/signin_header_helper_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/signin_manager.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/signin_manager_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/signin_switches.h
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/core/browser/signin_tracker_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/components/signin/ios/browser/account_consistency_service.mm
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/ios/chrome/browser/signin/about_signin_internals_factory.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/ios/chrome/browser/signin/signin_manager_factory.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller.mm
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/ios/web_view/internal/signin/web_view_signin_manager_factory.mm
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/services/identity/public/cpp/DEPS
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/services/identity/public/cpp/identity_manager_unittest.cc
[modify] https://crrev.com/ac55c997637a8092ceb6410367b220841b749d11/services/identity/public/cpp/identity_test_environment.cc

Comment 6 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9

commit 9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9
Author: Colin Blundell <blundell@chromium.org>
Date: Fri Nov 09 10:24:47 2018

Create target in //components/signin for shared code

//components/signin/core/browser contains three different types of code:

1. Code that forms the guts of IdentityManager and will form the guts of
the Identity Service implementation (e.g., SigninManager).

2. Code that will be clients of IdentityManager (e.g., SigninTracker).

3. Code that will be used on both sides (e.g., AccountInfo).

1 and 2 have already been split via a preceding CL. This CL creates 3.
To start off with, 3 contains two pieces of code that were already in
their own standalone targets for similar motivations as the above:
account_info.* and signin_metrics.*. In the future more code will
likely move in.

Bug:  901859 
Change-Id: Ibcae3c9f1ecff2dc7ccd013046b74c97b3dd2b7a
Reviewed-on: https://chromium-review.googlesource.com/c/1323114
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606783}
[modify] https://crrev.com/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9/components/sync/BUILD.gn
[modify] https://crrev.com/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9/services/identity/BUILD.gn
[modify] https://crrev.com/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9/services/identity/public/cpp/BUILD.gn
[modify] https://crrev.com/9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9/services/identity/public/cpp/account_info.typemap

Comment 7 by blundell@chromium.org, Nov 9

Status: Fixed (was: Started)
This split is complete. There will be further work to do to analyze the split, determine what to do about bad inclusions/dependencies, and refine it, but we can track that elsewhere.

Comment 8 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24599fc67d36d611bdde3dc74d2f069491c7b9ca

commit 24599fc67d36d611bdde3dc74d2f069491c7b9ca
Author: Colin Blundell <blundell@chromium.org>
Date: Fri Nov 09 12:35:40 2018

Change Identity Service impl to depend only on signin internals

Now that a distinct GN target exists just for the code backing
IdentityManager/Identity Service, change the Identity Service
implementation to depend only on that target. The change worked right
out of the box -- good validation of the initial split.

Bug:  901859 
Change-Id: I9b04ef952c34d9e9c0efcf137c55d41c8d616aff
Reviewed-on: https://chromium-review.googlesource.com/c/1323649
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606806}
[modify] https://crrev.com/24599fc67d36d611bdde3dc74d2f069491c7b9ca/services/identity/BUILD.gn

Comment 9 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/394bed001b098ae8b9b676be4b763726356f01c7

commit 394bed001b098ae8b9b676be4b763726356f01c7
Author: Colin Blundell <blundell@chromium.org>
Date: Wed Nov 14 13:47:14 2018

//components/signin: Move switches/prefs into shared target

We'll see where things go long-term, but for now, these seem more
intuitively like shared code than internal code.

Bug:  901859 
Change-Id: Ie3caff7ab36afa2453baa80199fd612e4ab9dfbb
Reviewed-on: https://chromium-review.googlesource.com/c/1331472
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607969}
[modify] https://crrev.com/394bed001b098ae8b9b676be4b763726356f01c7/components/signin/core/browser/BUILD.gn

Sign in to add a comment