New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901856 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: org.chromium.chrome.browser.feature_engagement.ScreenshotTabObserverTest#testScreenshotNumberReportingOne

Blocking:
issue 857505



Sign in to add a comment

org.chromium.chrome.browser.feature_engagement.ScreenshotTabObserverTest tests are flaky

Project Member Reported by Findit, Nov 5

Issue description

Components: Internals>FeatureEngagement
Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)
Another one?
Summary: org.chromium.chrome.browser.feature_engagement.ScreenshotTabObserverTest tests are flaky (was: org.chromium.chrome.browser.feature_engagement.ScreenshotTabObserverTest#testScreenshotNumberReportingOne is flaky)
testScreenshotActionReporting,
testScreenshotNumberReportingOne and
testScreenshotNumberReportingTwo are all flaky.
Blocking: 857505
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b81908f9760b608c9cf5f06355442b3304a0adc2

commit b81908f9760b608c9cf5f06355442b3304a0adc2
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Nov 06 12:23:19 2018

Disable flaky ScreenshotTabObserverTest tests.

TBR=petewil@chromium.org, jianli@chromium.org, dtrainor@chromium.org, isherman@chromium.org
NOTRY=True

Bug:  901856 
Change-Id: I61b14dca18356bb71618150795cddc7cce016574
Reviewed-on: https://chromium-review.googlesource.com/c/1318911
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605659}
[modify] https://crrev.com/b81908f9760b608c9cf5f06355442b3304a0adc2/chrome/android/javatests/src/org/chromium/chrome/browser/feature_engagement/ScreenshotTabObserverTest.java

Labels: -Sheriff-Chromium
With the tests disabled, removing sheriff label.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0700345be456a942b35884bd832e9bca7e8c7ec

commit d0700345be456a942b35884bd832e9bca7e8c7ec
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Nov 06 13:16:24 2018

Revert "Disable flaky ScreenshotTabObserverTest tests."

This reverts commit b81908f9760b608c9cf5f06355442b3304a0adc2.

Reason for revert: @DisabledTest: Cannot find symbol, oops.

Original change's description:
> Disable flaky ScreenshotTabObserverTest tests.
> 
> TBR=petewil@chromium.org, jianli@chromium.org, dtrainor@chromium.org, isherman@chromium.org
> NOTRY=True
> 
> Bug:  901856 
> Change-Id: I61b14dca18356bb71618150795cddc7cce016574
> Reviewed-on: https://chromium-review.googlesource.com/c/1318911
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605659}

TBR=isherman@chromium.org,petewil@chromium.org,dtrainor@chromium.org,jianli@chromium.org,hbos@chromium.org

Change-Id: I6ed97b424d0a649d7f02fd17a0569b6bd64f9069
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  901856 
Reviewed-on: https://chromium-review.googlesource.com/c/1318913
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605664}
[modify] https://crrev.com/d0700345be456a942b35884bd832e9bca7e8c7ec/chrome/android/javatests/src/org/chromium/chrome/browser/feature_engagement/ScreenshotTabObserverTest.java

Labels: Sheriff-Chromium
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a8f1c590008701d1be20a9df9e5db1083251b47

commit 5a8f1c590008701d1be20a9df9e5db1083251b47
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Nov 06 13:27:46 2018

Disable flaky ScreenshotTabObserverTest tests (retry).

TBR=petewil@chromium.org, jianli@chromium.org, dtrainor@chromium.org, isherman@chromium.org
NOTRY=True

Bug:  901856 
Change-Id: Icea45c9f384c1ad4a46e24a9fb4ee947a1b57a53
Reviewed-on: https://chromium-review.googlesource.com/c/1319593
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605665}
[modify] https://crrev.com/5a8f1c590008701d1be20a9df9e5db1083251b47/chrome/android/javatests/src/org/chromium/chrome/browser/feature_engagement/ScreenshotTabObserverTest.java

Labels: -Sheriff-Chromium
Status: Fixed (was: Assigned)
Mark Fixed since Findit notice is false alarm.

The test disabling patch[1] at #c9 is merged at
 Nov 6, 10:27PM
The findit pointed build is done at
 Nov 6, 8:27PM


[1] http://crrev.com/c/1319593 
Disable flaky ScreenshotTabObserverTest tests (retry).
Labels: -Sheriff-Chromium

Sign in to add a comment