New issue
Advanced search Search tips

Issue 901851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-11-19
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

SVG Text Doesn't Update Dynamically Unless I Resize

Reported by dick.w...@flatironschool.com, Nov 5

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.75 Safari/537.36

Steps to reproduce the problem:
1. Load up on Canary
2. Click the first Number on the left
3. 

What is the expected behavior?
I expect both the SVG Text and the p Tag to update.  Unfortunately, just the P tag is updating .

What went wrong?
It seems that though I'm updating the state in my component, the svg Text field isn't getting that new state.  However, if I resize by browser window, the new state comes through.

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 62.0.3202.75  Channel: n/a
OS Version: OS X 10.13.3
Flash Version:
 
svgStyle.css
2.7 KB View Download
SmallRating.js
665 bytes View Download
Labels: Needs-Feedback
NextAction: 2018-11-19
You're missing a html file, I believe. Please provide it. Looks like this needs React too. What version?

M-62 is so far back we can't do anything about it. What happens with M-70 or, even better, the current Canary (which you can install without changing a stable or beta install).
I realize now that this relies on a couple of things - I'll work up a more compact version and get that posted.  (Sorry about that, first bug report!)

This is also occuring on Canary.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 5

Cc: schenney@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 Deleted

Same as  bug 900452  or  bug 897752 ?
Labels: Needs-Feedback
I don't think it's the same as the other issues, though maybe. Both those were recent changes that modified behavior whereas this seems old.

I'll await the updated test case.
https://github.com/Gonzodamus/svgtexttest

I made a quickie version of it in a new react app.  Feel free to clone it down, `yarn start`, and muck around with it.  Currently using React 16.6.0, Chrome 70.0.3538.77.

This currently works as expected on Firefox 63.0.1.

Let me know if you need anything else!
And just in case I'm explaining poorly, here's the expected behavior https://imgur.com/qRLov7d

And here's what I'm getting 
https://imgur.com/z8Yej13
Based on the parts of the test it would seem this is something related to clip-path (contents) invalidation. Possibly also when applying to HTML content only.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 5

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Attempted minimization: http://jsfiddle.net/qgbj2L63/
Labels: Needs-Milestone
Cc: viswa.karala@chromium.org
Labels: Triaged-ET Needs-Feedback
Tried testing the issue with jsfiddle provided in comment# 11 and observations are as follows:
1) From M60-M64, on navigating to the URL provided in comment# 11, didn't observed any output of the jsfiddle
2) From M65-M72, on navigating to the URL provided in comment# 11, observed as 'FAIL' in the output of the jsfiddle

Reporter / fs@ Please find the attached screenshots for your reference, if possible could you please provide any other sample URL that reproduces the issue which help in further triaging it in better way.

Thanks!
901851 - M60 to M64.PNG
54.3 KB View Download
901851 - M65 to M72.PNG
79.9 KB View Download
I'd think that it's quite likely that this bug has been around quite a while - not sure what happens in the M60-64 range of builds, but it's probably a different issue. Nevertheless, here's a slightly tweaked version just in case:

http://jsfiddle.net/qgbj2L63/1/

(I don't really expect it to fare any better though.)

I can try to make a new one based on the things linked to in c#7, I currently lack the toolchain setup for that though.
Attaching a mildly stripped and modified of a built version of the react app in the repo in c#7 - in case that fares any better.
issue901851.zip
38.2 KB Download
Owner: f...@opera.com
Status: Assigned (was: Unconfirmed)
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac4f5a68966e43cd7778f9864de52d1446a82c37

commit ac4f5a68966e43cd7778f9864de52d1446a82c37
Author: Fredrik Söderquist <fs@opera.com>
Date: Tue Nov 06 19:44:13 2018

Need to walk ancestors when text descendants of LayoutSVGText changes

In LayoutSVGText::InvalidatePositioningValues - which is called when a
number of different modifications to text is performed - we only flagged
the node itself for layout/paint invalidation. We also need to walk the
ancestor chain in case the text is a descendant of a resource.
(A <clipPath> in this specific case.)

Bug:  901851 
Change-Id: Ia70860107616496e979c43a1d1a681def8b8c206
Reviewed-on: https://chromium-review.googlesource.com/c/1320069
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#605789}
[add] https://crrev.com/ac4f5a68966e43cd7778f9864de52d1446a82c37/third_party/WebKit/LayoutTests/css3/masking/clip-path-descendant-text-mutated-expected.html
[add] https://crrev.com/ac4f5a68966e43cd7778f9864de52d1446a82c37/third_party/WebKit/LayoutTests/css3/masking/clip-path-descendant-text-mutated.html
[modify] https://crrev.com/ac4f5a68966e43cd7778f9864de52d1446a82c37/third_party/blink/renderer/core/layout/svg/layout_svg_text.cc

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-11-19

Sign in to add a comment