New issue
Advanced search Search tips

Issue 901836 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 892754
issue 883538



Sign in to add a comment

Improve docs on reproducing libFuzzer bugs on Windows

Project Member Reported by metzman@chromium.org, Nov 5

Issue description

We've gotten feedback that there needs to be better documentation on reproducing libFuzzer bugs on Windows. 

One reason why this is the cases is because the reproduce tool doesn't work on Windows.

Since it probably isn't needed for libFuzzer bugs on Windows, because of the fewer configurations we use on libFuzzer on Windows than we do on Linux, just document how to reproduce these bugs better.
 
Components: Tools>Stability>libFuzzer
Owner: metzman@chromium.org
Status: Assigned (was: Untriaged)
Jonathan, when you'll be doing this, can you please fix the mb.py command here as well: https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md#builder-configurations

CMD doesn't seem to work well with single quotes.
Blocking: 883538 892754
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df04d745771012b354946fa1ad4751775321dcb0

commit df04d745771012b354946fa1ad4751775321dcb0
Author: Jonathan Metzman <metzman@chromium.org>
Date: Tue Nov 06 00:20:43 2018

[libFuzzer][Windows] Add docs on reproducing crashes

Add docs on reproducing libFuzzer crashes on Windows.
Make it clearer that reproduce tool is not for Windows.
Fix a command to work on cmd.exe

Bug:  901836 
Change-Id: Iabc5f8a2973053659addbb27d326ccb07c7910e2
Reviewed-on: https://chromium-review.googlesource.com/c/1318629
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605526}
[modify] https://crrev.com/df04d745771012b354946fa1ad4751775321dcb0/testing/libfuzzer/README.md
[modify] https://crrev.com/df04d745771012b354946fa1ad4751775321dcb0/testing/libfuzzer/getting_started.md
[modify] https://crrev.com/df04d745771012b354946fa1ad4751775321dcb0/testing/libfuzzer/reference.md
[add] https://crrev.com/df04d745771012b354946fa1ad4751775321dcb0/testing/libfuzzer/reproducing_on_windows.md

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c555cfbc7b89dc7065377d0a71269e25be4fd380

commit c555cfbc7b89dc7065377d0a71269e25be4fd380
Author: Jonathan Metzman <metzman@chromium.org>
Date: Tue Nov 06 15:31:42 2018

[libFuzzer][Windows] Improve docs

Fix link to reproduce tool.
Include note about using powershell.
Remove "> " from command.
Mention that document is for libFuzzer explicitly.
Be more consistent about capitalization of "libFuzzer".

TBR=mmoroz@chromium.org

Bug:  901836 
Change-Id: I9a91be5d01c2707366b1d8100cb0823c221aa82e
Reviewed-on: https://chromium-review.googlesource.com/c/1318918
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605684}
[modify] https://crrev.com/c555cfbc7b89dc7065377d0a71269e25be4fd380/testing/libfuzzer/README.md
[modify] https://crrev.com/c555cfbc7b89dc7065377d0a71269e25be4fd380/testing/libfuzzer/reproducing_on_windows.md

I configured ClusterFuzz to link to these docs in each libFuzzer on Win bug filed.
I also landed https://github.com/google/clusterfuzz-tools/pull/534 to ensure that anyone who comes across the reproduce tool will realize it cannot be used on Win.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/116a43d9b8b6c15ae5e17ac32f2279cadccc3d5f

commit 116a43d9b8b6c15ae5e17ac32f2279cadccc3d5f
Author: Jonathan Metzman <metzman@chromium.org>
Date: Wed Nov 07 00:03:07 2018

[libfuzzer] Make requested changes to docs

Bug:  901836 
Change-Id: I086972b916d5b46d497a4b57ae60f64627d25551
Reviewed-on: https://chromium-review.googlesource.com/c/1321569
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605881}
[modify] https://crrev.com/116a43d9b8b6c15ae5e17ac32f2279cadccc3d5f/testing/libfuzzer/reproducing_on_windows.md

Cc: -vabr@chromium.org

Sign in to add a comment