Issue metadata
Sign in to add a comment
|
Fling is broken in Canary |
||||||||||||||||||||||
Issue descriptionFling a page it will work once but then fail. It doesn't animate just stops dead.
,
Nov 5
Issue 901724 has been merged into this issue.
,
Nov 5
FWIW, if I let the fling complete then further flings work correctly. I can always break it, though, by trying to interrupt the first fling with a new fling in the reverse direction.
,
Nov 5
This helps a lot, thanks wanderview@
,
Nov 5
Also affects Chrome OS. Fling is broken if I change direction in the middle of a fling until a switch between tabs or cycle to & from a different window.
,
Nov 7
Issue 902445 has been merged into this issue.
,
Nov 7
Adding necessary labels and other info. Bisect info: Good build: 72.0.3598.0 Bad build: 72.0.3599.0 Regression range: https://chromium.googlesource.com/chromium/src/+log/72.0.3598.0..72.0.3599.0?pretty=fuller&n=10000 Good commit: 604706 Bad commit: 604707 Suspect CL: https://chromium.googlesource.com/chromium/src/+/0e58f2caab6a230fdb0f2b1993a44c2f4546c2f5
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b48b62c4392e7cd594d9fbe8684e93abc72aa1b commit 0b48b62c4392e7cd594d9fbe8684e93abc72aa1b Author: Sahel Sharify <sahel@chromium.org> Date: Thu Nov 08 21:27:02 2018 Fixed fling regression from registering observer on GSB instead of GFS. This cl resolves the regression that is caused by the following cl: https://chromium-review.googlesource.com/c/chromium/src/+/1313270 The previous cl calls UnregisterFlingSchedulerObserver() twice when a fling gets cancelled: once from gesture_event_queue while handling the generated GSE and once from FlingScheduler::DidStopFlingingOnBrowser. When there is only one active fling and the fling is not interrupted by another scroll/fling this works fine since the second Unregister call does nothing. However sometimes when a new fling replaces an active fling (e.g. starting a fling in the opposite direction of the currently active fling) the second Unregister call unregisters the observer that is added for the new fling. Since the observer is unregistered for the new fling no ProgressFling will get called till the user does a third fling. on the first ProgressFling call for the third fling, the controller tries to cancel the second fling and calls unregister which unregisters the observer for the third fling and the same thing happens for the rest of the flings from now on. This cl fixes the issue by not calling UnregisterFlingSchedulerObserver() in FlingScheduler::DidStopFlingingOnBrowser since it will get called once the generated GSE of the fling cancel is processed. Bug: 901831 Change-Id: I4d52f512ea38764fc64c580f6cac5ed4a32c1bee Reviewed-on: https://chromium-review.googlesource.com/c/1327145 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606606} [modify] https://crrev.com/0b48b62c4392e7cd594d9fbe8684e93abc72aa1b/content/browser/renderer_host/input/fling_scheduler.cc [modify] https://crrev.com/0b48b62c4392e7cd594d9fbe8684e93abc72aa1b/content/browser/renderer_host/input/fling_scheduler_android.cc [modify] https://crrev.com/0b48b62c4392e7cd594d9fbe8684e93abc72aa1b/content/browser/renderer_host/input/fling_scheduler_unittest.cc
,
Nov 9
Could reproduce the issue in today's Canary. dtapuska@ could you please confirm the fix on 72.0.3606.0?
,
Nov 9
Seems to be fixed in 72.0.3606.0 on pixel 2
,
Nov 9
,
Nov 9
,
Nov 27
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sahel@chromium.org
, Nov 5