New issue
Advanced search Search tips

Issue 901825 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Add credential provider pdbs to chromium symbol server

Project Member Reported by rogerta@chromium.org, Nov 5

Issue description

The credential provider creates two binaries that will be shipped to clients: the install and the credential provider COM dll.  Add pdbs for these components to the chromium symbol server.

 
CL https://chromium-review.googlesource.com/c/chromium/src/+/1301954 configures the buildbots to upload the pdbs to the symbol server, but the credential provider targets are not being built.
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cb75d74eed8109b92f3bcf77b09a248c3854df8

commit 5cb75d74eed8109b92f3bcf77b09a248c3854df8
Author: Roger Tawa <rogerta@chromium.org>
Date: Fri Nov 09 21:56:38 2018

Build credential provider targets as part of official build.

This is needed to make sure that credential provider pdbs make it to the
chromium symbol server.

Bug:  901825 
Change-Id: I23e116d0c7405c827fc3ed5385013a9e776644d2
Reviewed-on: https://chromium-review.googlesource.com/c/1315533
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606985}
[modify] https://crrev.com/5cb75d74eed8109b92f3bcf77b09a248c3854df8/BUILD.gn

Status: Verified (was: Started)
Verified with build 72.0.3616.0.

Sign in to add a comment