New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901777 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:[Print preview] Page preview appears blank from bottom.

Reported by vineetha...@etouch.net, Nov 5

Issue description

Chrome Version : 72.0.3602.0 (Official Build) Revision 3ed11c88d92e969dea664546a277cfb11eb15201-refs/branch-heads/3602@{#1} (32/64 bit)
OS :Windows(7,8,8.1,10), Mac (10.13.1, 10.13.6, 10.14.1) and Linux(14.04)

Steps to reproduce:
1. Launch chrome press 'Ctrl + P' to open print preview overlay.
2. Choose 'Custom' option for 'Margins' under 'More settings'.
3. Click on 'Fit to width' icon present on the RHS of overlay.
4. Now press tab to get focus on the bottom margin index and observe.

Actual Result  : Page preview appears blank from bottom.
Expected Result: Page preview should be seen properly.

This is a regression issue broken in ‘M-71’ and providing the bisect info below:
Good Build : 71.0.3551.3 (Revision : 590851)
Bad Build  : 71.0.3552.2 (Revision : 591210)

Chromium bisect info:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).

CHANGE-LOG URL:
  
https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1) Providing suspect using chromium bisect script because unable to perform bisect using 'per-revision' script.
2) Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting following error:
   - Error message on Mac OS:[Errno 2] No such file or directory error message
   - Error message on Windows OS: RuntimeError: We don't have enough builds to bisect.

Kindly refer the attached screen-cast.

Thank you..!
 
ActualVideo.mp4
1.7 MB View Download
ExpectedVideo.mp4
635 KB View Download
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required.
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Manipulation the PDF with the viewer controls while changing custom margins is a pretty unusual action, so should not be RBS. 
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/425cd7d0415a6494ccedb308fe3fc166b708b412

commit 425cd7d0415a6494ccedb308fe3fc166b708b412
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Nov 30 01:54:57 2018

Print Preview: Prevent empty grey area in plugin

When the user changes focus between custom margins inputs, this causes
the preview area to scroll, which should not occur since the iframe
containing the plugin is in a fixed location. Work around this issue
in the same way as in the old UI: manually set the offsets of the
preview area element to 0.

This workaround has the downside that the newly focused input is not
visible to the user, and therefore key events cause another scroll,
which is not addressed by the workaround. To address this issue, after
setting the offsets, inform the plugin that it should scroll to make
the input visible.

Bug:  901777 
Change-Id: If310b84229fd53ffaee449699b8ac8a13806101c
Reviewed-on: https://chromium-review.googlesource.com/c/1351950
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612506}
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/pdf/pdf_scripting_api.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/pdf/pdf_viewer.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/print_preview/new/margin_control.html
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/print_preview/new/margin_control.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/print_preview/new/margin_control_container.html
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/print_preview/new/plugin_proxy.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/test/data/webui/print_preview/custom_margins_test.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/425cd7d0415a6494ccedb308fe3fc166b708b412/chrome/test/data/webui/print_preview/plugin_stub.js

Status: Fixed (was: Assigned)

Sign in to add a comment