New issue
Advanced search Search tips

Issue 901774 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Please change text highlight colour from blue to make it easier to see what's selected in Elements tab

Reported by l...@mcmullen.im, Nov 5

Issue description

Chrome Version       : 69.0.3497.100
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:N/A
    Firefox:N/A
    IE/Edge:N/A

What steps will reproduce the problem?
1.Open dev tools with dark theme enabled, switch to Elements tab, choose an element, press F2 or rt-click and Edit as HTML, select some text

What is the expected result?
Would be great if the selected text highlight colour was not blue as it makes it very difficult to see what is selected with blue on the dark background.

What happens instead of that?
The selected text is highlighted in blue which makes it very difficult to see on the dark background.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36


The dark theme is excellent, I love it apart from this one issue but I use the edit as html feature very often so it's a constant frustration when I can't quite make out what is selected!

Thanks,
Lee
 
Capture.PNG
31.5 KB View Download
Components: Platform>DevTools
Labels: Needs-Milestone
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Target-72 M-72 FoundIn-71 FoundIn-70 FoundIn-72 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Thanks for filling the issue...

As per comment #0, it seems to be a feature request. Hence, marking it as untriaged for further inputs from Dev team.

Thanks...!
Labels: -Type-Bug Type-Feature
Owner: einbinder@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f778f842b76b239be502ec52538c3f639a93b954

commit f778f842b76b239be502ec52538c3f639a93b954
Author: Joel Einbinder <einbinder@chromium.org>
Date: Fri Nov 30 23:28:15 2018

DevTools: Make CodeMirror dark theme behave in shadow dom

cmdevtools.css was looking for the dark theme class on the body in
order to apply its dark theme. When CodeMirror was attached
in a shadow dom, like in elements panel, this broke.

Bug:  901774 
Change-Id: I67eab73721b8ba7642a862220bafa1cb0364146b
Reviewed-on: https://chromium-review.googlesource.com/c/1356231
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612837}
[modify] https://crrev.com/f778f842b76b239be502ec52538c3f639a93b954/third_party/blink/renderer/devtools/front_end/text_editor/cmdevtools.css

Status: Fixed (was: Untriaged)

Sign in to add a comment