Don't run H264 Tast tests on builders using Chromium instead of Chrome |
||||
Issue descriptionhttps://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8930722874630067104 2018/11/04 23:06:07 [23:06:06.791] Unloading vivid 2018/11/04 23:06:07 [23:06:06.804] External command failed: exit status 1 2018/11/04 23:06:07 [23:06:06.805] Command: modprobe -r vivid 2018/11/04 23:06:07 [23:06:06.805] Uncaptured output: modprobe: FATAL: Module vivid is in use. Looks like the test failed but vivid was still in use so the test failed to remove vivid in defer function. There is also an JS error: 2018/11/04 23:06:07 [23:06:06.787] Error at webrtc.go:137: Got JS error: failed-to-munge: Missing a=rtpmap entry for |codec| = H264 in v=0
,
Nov 5
Lowering the priority as https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1312537 has no CQ+1, so it won't run in the next build. Thanks Keiichi for the quick reply.
,
Nov 6
I found the cause of this failure. It's because amd64-generic-paladin uses Chromium instead of Chrome. Chromium cannot decode and encode H.264 videos. Since betty builder uses official (internal) Chrome, we cannot catch this problem in betty-release. So, we need to have a way to skip H.264 tests on such builder. I think that it's good to have a software dependency that means that it requires official Chrome, rather than Chromium. For this purpose, I created crrev.com/c/1319354, crrev.com/c/1319292 and crrev.com/c/1319294. Please take a look.
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/7e0a96aceb089de8baffa068258215fd1c7a1ba1 commit 7e0a96aceb089de8baffa068258215fd1c7a1ba1 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Sat Nov 17 03:50:40 2018 tast: Add "chrome_internal" software dependency Add a dependency "chrome_internal" for features that requiring official (internal) Chrome, rather than Chromium. e.g. Chromium cannot encode and decode H.264 videos. BUG= chromium:901763 , chromium:900857 TEST=tast run for non-internal VM with CL:1319294 CQ-DEPEND=CL:1319354 Change-Id: I73affe2aa1e8729d8b914dcda8d72bdc5f6f6e26 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1319292 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/7e0a96aceb089de8baffa068258215fd1c7a1ba1/src/chromiumos/cmd/local_test_runner/main.go [modify] https://crrev.com/7e0a96aceb089de8baffa068258215fd1c7a1ba1/docs/test_dependencies.md
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7c840e6cd4cc7559b6363a9f95384d2421356786 commit 7c840e6cd4cc7559b6363a9f95384d2421356786 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Sat Nov 17 03:50:40 2018 tast-use-flags: Add chrome_internal flag to IUSE. amd64-generic builder in Chromium/ChromeOS infra uses Chromium, rather than Chrome. Since Chromium's features are somehow limited, we want to skip some tests on the builder. For example, encoding and decoding H.264 video are unavailable in Chromium. This patch makes tast-use-flags capture chrome_internal USE flags so that we can skip test cases requiring Chrome (non-Chromium) features. BUG= chromium:901763 , chromium:900857 TEST=emerge tast-use-flags Change-Id: Ie7abc3fe0c208bad640f767c5b5a6314aeca959a Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1319354 [rename] https://crrev.com/7c840e6cd4cc7559b6363a9f95384d2421356786/chromeos-base/tast-use-flags/tast-use-flags-0.0.1-r14.ebuild [modify] https://crrev.com/7c840e6cd4cc7559b6363a9f95384d2421356786/chromeos-base/tast-use-flags/tast-use-flags-0.0.1.ebuild
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/7226517aa5881a2b982c065a0cc441d15d4ba31d commit 7226517aa5881a2b982c065a0cc441d15d4ba31d Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Sat Nov 17 03:50:39 2018 video: Add "chrome_internal" dependency in tests playing H264 videos Add "chrome_internal" dependency in tests using H.264 encoding/decoding features on browsers; H.264 encoding and decoding are available in Chrome, but not in Chromium. BUG= chromium:901763 , chromium:900857 TEST=tast run -buildlocalrunner -checktestdeps always \ <non-internal amd64-generic VM> video.* with CL:1319354 and CL:1319292 CQ-DEPEND=CL:1319354, CL:1319292 Change-Id: I8e88124a02dfd6036d1f6c74031450738933c5e8 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1319294 Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/7226517aa5881a2b982c065a0cc441d15d4ba31d/src/chromiumos/tast/local/bundles/cros/video/webrtc_peer_conn_camera_h264_perf.go [modify] https://crrev.com/7226517aa5881a2b982c065a0cc441d15d4ba31d/src/chromiumos/tast/local/bundles/cros/video/webrtc_peer_conn_camera_h264.go [modify] https://crrev.com/7226517aa5881a2b982c065a0cc441d15d4ba31d/src/chromiumos/tast/local/bundles/cros/video/playback_perf_h264.go [modify] https://crrev.com/7226517aa5881a2b982c065a0cc441d15d4ba31d/src/chromiumos/tast/local/bundles/cros/video/play_h264.go
,
Nov 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cychiang@google.com
, Nov 5