1.1%-8.2% regression in memory.desktop at 604883:604916 |
||||||||
Issue descriptionSee the link to graphs below.
,
Nov 5
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/131b0609e40000
,
Nov 5
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/131b0609e40000 [Intl] Move cachedOrNewService to C++ w/o caching by ftang@chromium.org https://chromium.googlesource.com/v8/v8/+/dffaff7769dd89670a897d1adc50639b8655bf39 memory:chrome:all_processes:reported_by_chrome:v8:effective_size: 2.74e+06 → 2.907e+06 (+1.671e+05) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
,
Nov 5
It might be caused by create the instance over and over again before GC kick in.
,
Nov 6
See for more discussion on this: https://bugs.chromium.org/p/chromium/issues/detail?id=901748#c7
,
Nov 9
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7aced29990db03006745ea0817ed23b3fd6d5760 commit 7aced29990db03006745ea0817ed23b3fd6d5760 Author: Frank Tang <ftang@chromium.org> Date: Tue Nov 13 19:56:09 2018 [Intl] Cache intl objects in isolate Remove old code in v8::Date::DateTimeConfigurationChangeNotification Add code to clear date time cache object in isolate. Running benchmark python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Strings/StringLocaleCompare" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Dates" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Numbers" \ test/js-perf-test/JSTests.json BEFORE THE FIX: StringLocaleCompare-Strings(Score): 184287 toLocaleDateString-Dates(Score): 10456 toLocaleString-Dates(Score): 10436 toLocaleTimeString-Dates(Score): 10700 toLocaleString-Numbers(Score): 2935 AFTER THE FIX in Patch Set 13: StringLocaleCompare-Strings(Score): 57470000 toLocaleDateString-Dates(Score): 6141000 toLocaleString-Dates(Score): 4093000 toLocaleTimeString-Dates(Score): 6323000 toLocaleString-Numbers(Score): 3371000 Bug: chromium:901748, chromium:901747 , v8:5751 Change-Id: I7578e2ced0fe967dce6424d17f15ab806cc522be Reviewed-on: https://chromium-review.googlesource.com/c/1320892 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57484} [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/api.cc [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/builtins/builtins-date.cc [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/builtins/builtins-intl.cc [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/isolate.cc [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/isolate.h [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/objects/intl-objects.cc [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/objects/intl-objects.h [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/objects/js-date-time-format.cc [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/objects/js-date-time-format.h [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/objects/js-number-format.cc [modify] https://crrev.com/7aced29990db03006745ea0817ed23b3fd6d5760/src/objects/js-number-format.h
,
Nov 13
,
Nov 14
Have the graphs recovered? I'd like to wait until they do before closing this.
,
Nov 15
Looks like we're all recovered here. Nice work Frank!
,
Nov 15
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 5