[Chameleon_audio, vayne] Audio tests failing due to different node names |
|||||||
Issue descriptionNami - vayne Failed in audio_BasicInternalCardNode audio_IternalCardNodes since its internalMicrophone is FRONT_MIC You can see error messages: 1. Wrong input node(s) selected: ['FRONT_MIC'] expected:['INTERNAL_MIC'] 2. Wrong input node(s) plugged: ['HOTWORD', 'FRONT_MIC', 'POST_DSP_LOOPBACK', 'POST_MIX_LOOPBACK'] expected: ['POST_DSP_LOOPBACK', 'POST_MIX_LOOPBACK', 'INTERNAL_MIC']! from stainless: https://stainless.corp.google.com/search?view=matrix&row=build&col=board&first_date=2018-10-08&last_date=2018-11-05&test=audio_AudioBasicInternalMicrophone%7Caudio_InternalCardNodes&build=R72&board=nami&status=GOOD&status=WARN&status=FAIL&status=ERROR&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false
,
Nov 6
I guess this should be expected and we have to change the expectations in both tests by: - changing the test - cras_configs.py
,
Nov 6
I just sent out CLs to fix this crrev.com/c/1317279 crrev.com/c/1317280 blocked by commit queue.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1767f85ec83f414cc4c4077259b748863d03fa90 commit 1767f85ec83f414cc4c4077259b748863d03fa90 Author: paulhsia <paulhsia@chromium.org> Date: Wed Nov 07 04:19:23 2018 [autotest] Add customized internal mic for nami For test audio_AudioBasicInternalMicrophone. We need to set expected internal mic to 'FRONT_MIC' for (board, model) = (nami, vayne). BUG= chromium:901723 TEST=Run audio_AudioBasicInternalMicrophone on DUT Change-Id: I3ccb0d43ad2d035d98ac1e371ae25e2526c7a256 Reviewed-on: https://chromium-review.googlesource.com/1317279 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> [modify] https://crrev.com/1767f85ec83f414cc4c4077259b748863d03fa90/client/cros/audio/cras_configs.py
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/127c084d1f4bac49b564e1ce171577cb84197565 commit 127c084d1f4bac49b564e1ce171577cb84197565 Author: paulhsia <paulhsia@chromium.org> Date: Wed Nov 07 04:19:23 2018 [autotest] Add customized internal mic and hotword for nami For test audio_InternalCardNodes. We need to set expected internal mic to 'FRONT_MIC' for (board, model) = (nami, vayne) and add 'HOTWORD' to nami boards. BUG= chromium:901723 TEST=Run audio_InternalCardNodes on DUT Change-Id: I434e9e5f41fdf93339ed32cbba807427f58883a8 Reviewed-on: https://chromium-review.googlesource.com/1317280 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> [modify] https://crrev.com/127c084d1f4bac49b564e1ce171577cb84197565/client/cros/audio/audio_spec.py [modify] https://crrev.com/127c084d1f4bac49b564e1ce171577cb84197565/client/cros/audio/cras_configs.py
,
Nov 7
These are test changes and request merge to m71 and m70 to make test dashboard green. Thanks!
,
Nov 7
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 7
Approved for ChromeOS M71 and M70
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c138b4c223f45d10aa7bf5a52913250c0dcdb716 commit c138b4c223f45d10aa7bf5a52913250c0dcdb716 Author: paulhsia <paulhsia@chromium.org> Date: Thu Nov 08 03:57:53 2018 [autotest] Add customized internal mic for nami For test audio_AudioBasicInternalMicrophone. We need to set expected internal mic to 'FRONT_MIC' for (board, model) = (nami, vayne). BUG= chromium:901723 TEST=Run audio_AudioBasicInternalMicrophone on DUT Change-Id: I3ccb0d43ad2d035d98ac1e371ae25e2526c7a256 Previous-Reviewed-on: https://chromium-review.googlesource.com/1317279 (cherry picked from commit 3c0054b414b93103b1fa0a4d281ac9a23c4af98a) Reviewed-on: https://chromium-review.googlesource.com/c/1325251 Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> [modify] https://crrev.com/c138b4c223f45d10aa7bf5a52913250c0dcdb716/client/cros/audio/cras_configs.py
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf358922b9d7e7f61fec9d3a4a734642a09c8418 commit cf358922b9d7e7f61fec9d3a4a734642a09c8418 Author: paulhsia <paulhsia@chromium.org> Date: Thu Nov 08 03:57:55 2018 [autotest] Add customized internal mic and hotword for nami For test audio_InternalCardNodes. We need to set expected internal mic to 'FRONT_MIC' for (board, model) = (nami, vayne) and add 'HOTWORD' to nami boards. BUG= chromium:901723 TEST=Run audio_InternalCardNodes on DUT Change-Id: I434e9e5f41fdf93339ed32cbba807427f58883a8 Previous-Reviewed-on: https://chromium-review.googlesource.com/1317280 (cherry picked from commit bb1f9a274c5509698eda40f23a3f591f06d12281) Reviewed-on: https://chromium-review.googlesource.com/c/1325252 Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> [modify] https://crrev.com/cf358922b9d7e7f61fec9d3a4a734642a09c8418/client/cros/audio/audio_spec.py [modify] https://crrev.com/cf358922b9d7e7f61fec9d3a4a734642a09c8418/client/cros/audio/cras_configs.py
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0324c4477b8c294c118120bb464ce2ac527a435d commit 0324c4477b8c294c118120bb464ce2ac527a435d Author: paulhsia <paulhsia@chromium.org> Date: Thu Nov 08 05:19:02 2018 [autotest] Add customized internal mic for nami For test audio_AudioBasicInternalMicrophone. We need to set expected internal mic to 'FRONT_MIC' for (board, model) = (nami, vayne). BUG= chromium:901723 TEST=Run audio_AudioBasicInternalMicrophone on DUT Change-Id: I3ccb0d43ad2d035d98ac1e371ae25e2526c7a256 Previous-Reviewed-on: https://chromium-review.googlesource.com/1317279 (cherry picked from commit 62843bac51b504d21329cc0379c07ff567806b5a) Reviewed-on: https://chromium-review.googlesource.com/c/1325253 Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> [modify] https://crrev.com/0324c4477b8c294c118120bb464ce2ac527a435d/client/cros/audio/cras_configs.py
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c0057728265ed7d713e9387cf07c5f88e931dbdb commit c0057728265ed7d713e9387cf07c5f88e931dbdb Author: paulhsia <paulhsia@chromium.org> Date: Thu Nov 08 05:19:03 2018 [autotest] Add customized internal mic and hotword for nami For test audio_InternalCardNodes. We need to set expected internal mic to 'FRONT_MIC' for (board, model) = (nami, vayne) and add 'HOTWORD' to nami boards. BUG= chromium:901723 TEST=Run audio_InternalCardNodes on DUT Change-Id: I434e9e5f41fdf93339ed32cbba807427f58883a8 Previous-Reviewed-on: https://chromium-review.googlesource.com/1317280 (cherry picked from commit adbf7c94e578631603a8bc8c7c0800f62e5485b3) Reviewed-on: https://chromium-review.googlesource.com/c/1325254 Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> [modify] https://crrev.com/c0057728265ed7d713e9387cf07c5f88e931dbdb/client/cros/audio/audio_spec.py [modify] https://crrev.com/c0057728265ed7d713e9387cf07c5f88e931dbdb/client/cros/audio/cras_configs.py
,
Nov 8
Merge-Merged. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sontis@chromium.org
, Nov 5