New issue
Advanced search Search tips

Issue 901714 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Move utility functions in tray_vpn.h to VpnList

Project Member Reported by tetsui@chromium.org, Nov 5

Issue description

As old SystemTray is removed, VpnList is the more appropriate place to put these utility functions.

https://cs.chromium.org/chromium/src/ash/system/network/vpn_list.h


 

Comment 1 by tetsui@chromium.org, Jan 17 (6 days ago)

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc108a41453a0fd0d99f142ca69a5a0e71bd751e

commit fc108a41453a0fd0d99f142ca69a5a0e71bd751e
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Jan 18 01:53:02 2019

Unified: Rename tray_vpn.h to vpn_util.h.

This CL moves VPN tray related functions to vpn_util namespace.

TEST=trybot pass
BUG= 901714 

Change-Id: I5a0506e88638a1962144036c6b1f539bf08feb7b
Reviewed-on: https://chromium-review.googlesource.com/c/1416797
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623952}
[modify] https://crrev.com/fc108a41453a0fd0d99f142ca69a5a0e71bd751e/ash/BUILD.gn
[delete] https://crrev.com/071aec40f0f5c52c358c60ab2296af3724cc5c7a/ash/system/network/tray_vpn.h
[modify] https://crrev.com/fc108a41453a0fd0d99f142ca69a5a0e71bd751e/ash/system/network/vpn_feature_pod_controller.cc
[rename] https://crrev.com/fc108a41453a0fd0d99f142ca69a5a0e71bd751e/ash/system/network/vpn_util.cc
[add] https://crrev.com/fc108a41453a0fd0d99f142ca69a5a0e71bd751e/ash/system/network/vpn_util.h

Comment 3 by tetsui@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Started)

Sign in to add a comment