New issue
Advanced search Search tips

Issue 901713 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Combine UnifiedDetailedViewDelegate with DetailedViewDelegate

Project Member Reported by tetsui@chromium.org, Nov 5

Issue description

As SystemTrayItemDetailedViewDelegate is removed, UnifiedDetailedViewDelegate is the only subclass of DetailedViewDelegate.

https://cs.chromium.org/chromium/src/ash/system/unified/unified_detailed_view_delegate.h
 

Comment 1 by tetsui@chromium.org, Jan 16 (6 days ago)

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd07dddd92c7b386b7185229481b10ff5784c58c

commit bd07dddd92c7b386b7185229481b10ff5784c58c
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Jan 17 03:35:58 2019

Merge UnifiedDetailedViewDelegate w/ parent class.

This CL merges UnifiedDetailedViewDelegate with its parent class,
DetailedViewDelegate. Previously, there was a DetailedViewDelegate for
old SystemTray, but the old one is now removed.

TEST=trybot pass
BUG= 901713 

Change-Id: Ibd4aa0d6e09fc6fb0b8ee452e6dc6e2c8a6baa37
Reviewed-on: https://chromium-review.googlesource.com/c/1414810
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623557}
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/BUILD.gn
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/accessibility/tray_accessibility_unittest.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/accessibility/unified_accessibility_detailed_view_controller.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/audio/unified_audio_detailed_view_controller.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/bluetooth/unified_bluetooth_detailed_view_controller.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/cast/unified_cast_detailed_view_controller.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/ime/unified_ime_detailed_view_controller.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/locale/unified_locale_detailed_view_controller.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/network/unified_network_detailed_view_controller.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/network/unified_vpn_detailed_view_controller.cc
[rename] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/tray/detailed_view_delegate.cc
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/tray/detailed_view_delegate.h
[delete] https://crrev.com/c32b4bb7e24afff87e887acd0d5ed685281e528e/ash/system/unified/unified_detailed_view_delegate.h
[modify] https://crrev.com/bd07dddd92c7b386b7185229481b10ff5784c58c/ash/system/unified/unified_notifier_settings_controller.cc

Comment 3 by tetsui@chromium.org, Jan 17 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment