New issue
Advanced search Search tips

Issue 901712 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Combine TimeView with BaseDateTimeView

Project Member Reported by tetsui@chromium.org, Nov 5

Issue description

As DateView is removed, TimeView is the only subclass of BaseDateTimeView.

https://cs.chromium.org/chromium/src/ash/system/date/date_view.h
 

Comment 1 by tetsui@chromium.org, Jan 17 (6 days ago)

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b20f0034bae4ae8eaabd659ff17da0fbce00b893

commit b20f0034bae4ae8eaabd659ff17da0fbce00b893
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Jan 18 03:30:11 2019

Unified: Merge TimeView with BaseDateTimeView.

This CL merges TimewView with its parent class,
BaseDateTimeView. Previously, there was another subclass DateView,
but now TimeView is the sole subclass of BaseDateTimewView.

TEST=trybot pass
BUG= 901712 

Change-Id: I16296bd7ba973e8f17cdbdf0bf3fac78663a0b3f
Reviewed-on: https://chromium-review.googlesource.com/c/1415059
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623990}
[modify] https://crrev.com/b20f0034bae4ae8eaabd659ff17da0fbce00b893/ash/system/date/date_view.cc
[modify] https://crrev.com/b20f0034bae4ae8eaabd659ff17da0fbce00b893/ash/system/date/date_view.h

Comment 3 by tetsui@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Started)

Sign in to add a comment