New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901671 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Merge v.4.14.79 into chromeos-4.14

Project Member Reported by groeck@chromium.org, Nov 4

Issue description

Merge v4.14.79 into chromeos-4.14

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a93ded5e253fb92fdd1b2ddeb5b980edb204461a

commit a93ded5e253fb92fdd1b2ddeb5b980edb204461a
Author: Guenter Roeck <groeck@chromium.org>
Date: Mon Nov 05 19:40:22 2018

CHROMIUM: Merge 'v4.14.79' into chromeos-4.14

Merge of v4.14.79 into chromeos-4.14

Changelog:
----------------------------------------------------------------
Ake Koomsin (1):
      virtio_net: avoid using netif_tx_disable() for serializing tx routine

Alex Vesker (1):
      IB/ipoib: Fix lockdep issue found on ipoib_ib_dev_heavy_flush

Alexandre Belloni (1):
      soc: fsl: qbman: qman: avoid allocating from non existing gen_pool

Andrei Otcheretianski (2):
      mac80211: Always report TX status
      cfg80211: reg: Init wiphy_idx in regulatory_hint_core()

Arnaldo Carvalho de Melo (1):
      perf python: Use -Wno-redundant-decls to build with PYTHON=python3

Arnd Bergmann (2):
      scsi: aacraid: address UBSAN warning regression
      net: stmmac: mark PM functions as __maybe_unused

Arthur Kiyanovski (2):
      net: ena: fix warning in rmmod caused by double iounmap
      net: ena: fix NULL dereference due to untimely napi initialization

Ben Hutchings (1):
      scsi: qla2xxx: Avoid double completion of abort command

Bob Copeland (1):
      mac80211: fix pending queue hang due to TX_DROP

Brian King (1):
      scsi: ibmvfc: Avoid unnecessary port relogin

Chris Paterson (1):
      ARM: dts: r8a7790: Correct critical CPU temperature

Christoph Paasch (1):
      sch_netem: restore skb->dev after dequeuing from the rbtree

Colin Ian King (1):
      drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path

Cong Wang (2):
      llc: set SOCK_RCU_FREE in llc_sap_add_socket()
      net: drop skb on failure in ip_check_defrag()

Corentin Labbe (1):
      powerpc/pseries: Add empty update_numa_cpu_lookup_table() for NUMA=n

Dan Carpenter (1):
      x86/paravirt: Fix some warning messages

Dan Williams (1):
      tools/testing/nvdimm: unit test clear-error commands

Daniel Mack (1):
      libertas: call into generic suspend code before turning off power

David Ahern (2):
      netfilter: bridge: Don't sabotage nf_hook calls from an l3mdev
      net/ipv6: Fix index counter for unicast addresses in in6_dump_addrs

David Howells (3):
      rxrpc: Don't check RXRPC_CALL_TX_LAST after calling rxrpc_rotate_tx_window()
      rxrpc: Only take the rwind and mtu values from latest ACK
      rxrpc: Fix connection-level abort handling

David S. Miller (1):
      sparc64: Fix regression in pmdp_invalidate().

Davide Caratti (2):
      be2net: don't flip hw_features when VXLANs are added/deleted
      net/sched: cls_api: add missing validation of netlink attributes

Dimitris Michailidis (1):
      net: fix pskb_trim_rcsum_slow() with odd trim offset

Doug Ledford (1):
      IB/rxe: put the pool on allocation failure

Emmanuel Grumbach (1):
      iwlwifi: fix the ALIVE notification layout

Eric Dumazet (2):
      ipv6: mcast: fix a use-after-free in inet6_mc_check
      net/mlx5e: fix csum adjustments caused by RXFCS

Florian Fainelli (10):
      ARM: dts: BCM63xx: Fix incorrect interrupt specifiers
      asix: Check for supported Wake-on-LAN modes
      ax88179_178a: Check for supported Wake-on-LAN modes
      lan78xx: Check for supported Wake-on-LAN modes
      sr9800: Check for supported Wake-on-LAN modes
      r8152: Check for supported Wake-on-LAN Modes
      smsc75xx: Check for Wake-on-LAN modes
      smsc95xx: Check for Wake-on-LAN modes
      net: phy: phylink: Don't release NULL GPIO
      net: bcmgenet: Poll internal PHY for GENETv5

Fugang Duan (1):
      net: fec: don't dump RX FIFO register when not available

Geert Uytterhoeven (1):
      cifs: Use ULL suffix for 64-bit constant

Govindarajulu Varadarajan (1):
      enic: do not overwrite error code

Greg Kroah-Hartman (1):
      Linux 4.14.79

Guenter Roeck (2):
      locking/ww_mutex: Fix runtime warning in the WW mutex selftest
      Merge remote-tracking branch 'origin/linux/v4.14.79' into merge/chromeos-4.14-v4.14.79

Hangbin Liu (1):
      bridge: do not add port to router list when receives query with source 0.0.0.0

Heiner Kallweit (1):
      r8169: fix NAPI handling under high load

Huy Nguyen (1):
      net/mlx5: Take only bit 24-26 of wqe.pftype_wq for page fault type

Ido Schimmel (1):
      rtnetlink: Disallow FDB configuration for non-Ethernet device

Israel Rukshin (1):
      net/mlx5: Fix mlx5_get_vector_affinity function

Jaime CaamaƱo Ruiz (1):
      openvswitch: Fix push/pop ethernet validation

Jakub Kicinski (1):
      net: sched: gred: pass the right attribute to gred_change_table_def()

James Chapman (1):
      l2tp: remove configurable payload offset

Jason Gunthorpe (1):
      IB/usnic: Update with bug fixes from core code

Jason Wang (1):
      vhost: Fix Spectre V1 vulnerability

Jiri Olsa (1):
      perf/ring_buffer: Prevent concurent ring buffer access

Johannes Berg (1):
      mac80211: TDLS: fix skb queue/priority assignment

John Fastabend (1):
      bpf: sockmap, map_release does not hold refcnt for pinned maps

John Keeping (1):
      mmc: dw_mmc-rockchip: correct property names in debug

Jouni Malinen (1):
      cfg80211: Address some corner cases in scan result channel updating

Julian Wiedmann (1):
      s390/qeth: fix error handling in adapter command callbacks

Kan Liang (1):
      perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX

KarimAllah Ahmed (1):
      KVM: x86: Update the exit_qualification access bits while walking an address

Kevin Hao (2):
      net: phy: realtek: Use the dummy stubs for MMD register access for rtl8211b
      net: phy: Add general dummy stubs for MMD register access

Khazhismel Kumykov (1):
      fs/fat/fatent.c: add cond_resched() to fat_count_free_clusters()

Kimmo Rautkoski (1):
      mtd: spi-nor: Add support for is25wp series chips

Larry Chen (1):
      ocfs2: fix crash in ocfs2_duplicate_clusters_by_page()

Liad Kaufman (1):
      iwlwifi: dbg: allow wrt collection before ALIVE

Lubomir Rintel (1):
      pxa168fb: prepare the clock

Maciej W. Rozycki (1):
      declance: Fix continuation with the adapter identification message

Marcel Ziswiler (1):
      ARM: tegra: Fix ULPI regression on Tegra20

Marcelo Ricardo Leitner (1):
      sctp: fix race on sctp_id2asoc

Martin K. Petersen (1):
      scsi: sd: Remember that READ CAPACITY(16) succeeded

Martin Willi (1):
      mac80211_hwsim: do not omit multicast announce of first added radio

Masahiro Yamada (1):
      kconfig: fix the rule of mainmenu_stmt symbol

Masashi Honma (2):
      nl80211: Fix possible Spectre-v1 for NL80211_TXRATE_HT
      nl80211: Fix possible Spectre-v1 for CQM RSSI thresholds

Matias Karhumaa (1):
      Bluetooth: SMP: fix crash in unpairing

Michael Neuling (1):
      selftests/powerpc: Add ptrace hw breakpoint test

Michal Simek (1):
      net: macb: Clean 64b dma addresses if they are not detected

Milan Broz (1):
      dm integrity: fail early if required HMAC key is not available

Natarajan, Janakarajan (1):
      perf/x86/amd/uncore: Set ThreadMask and SliceMask for L3 Cache perf events

Nathan Chancellor (5):
      qed: Avoid implicit enum conversion in qed_set_tunn_cls_info
      qed: Fix mask parameter in qed_vf_prep_tunn_req_tlv
      qed: Avoid implicit enum conversion in qed_roce_mode_to_flavor
      qed: Avoid constant logical operation warning in qed_vf_pf_acquire
      qed: Avoid implicit enum conversion in qed_iwarp_parse_rx_pkt

Nayna Jain (1):
      tpm: move the delay_msec increment after sleep in tpm_transmit()

Niklas Cassel (1):
      net: stmmac: Fix stmmac_mdio_reset() when building stmmac as modules

Nikolay Aleksandrov (2):
      net: bridge: remove ipv6 zero address check in mcast queries
      net: ipmr: fix unresolved entry dumps

Noa Osherovich (1):
      IB/mlx5: Avoid passing an invalid QP type to firmware

Paolo Abeni (2):
      selftests: rtnetlink.sh explicitly requires bash.
      udp6: fix encap return code for resubmitting

Paul Burton (2):
      MIPS: Workaround GCC __builtin_unreachable reordering bug
      compiler.h: Allow arch-specific asm/compiler.h

Peter Xu (1):
      kvm: x86: fix WARN due to uninitialized guest FPU state

Peter Zijlstra (1):
      perf/core: Fix perf_pmu_unregister() locking

Phil Elwell (1):
      lan78xx: Don't reset the interface on open

Phil Reid (1):
      iio: buffer: fix the function signature to match implementation

Phil Sutter (1):
      net: sched: Fix for duplicate class dump

Philipp Zabel (1):
      media: uvcvideo: Fix driver reference counting

Qu Wenruo (1):
      btrfs: quota: Set rescan progress to (u64)-1 if we hit last leaf

Rasmus Villemoes (1):
      perf tools: Disable parallelism for 'make clean'

Rickard x Andersson (1):
      net: fec: fix rare tx timeout

Ross Lagerwall (2):
      xen-netfront: Update features after registering netdev
      xen-netfront: Fix mismatched rtnl_unlock

Saeed Mahameed (1):
      net/mlx5: Fix build break when CONFIG_SMP=n

Sandipan Das (1):
      perf tests: Fix indexing when invoking subtests

Sara Sharon (1):
      iwlwifi: mvm: check for short GI only for OFDM

Sascha Hauer (1):
      ARM: dts: imx53-qsb: disable 1.2GHz OPP

Sasha Levin (1):
      Revert "netfilter: ipv6: nf_defrag: drop skb dst before queueing"

Sean Tranchetti (3):
      xfrm: validate template mode
      net: qualcomm: rmnet: Skip processing loopback packets
      net: udp: fix handling of CHECKSUM_COMPLETE packets

Shay Agroskin (1):
      net/mlx5e: Refine ets validation function

Shuah Khan (1):
      usbip: vhci_hcd: update 'status' file header and format

Sowmini Varadhan (2):
      xfrm: reset transport header back to network header after all input transforms ahave been applied
      xfrm: reset crypto_done when iterating over multiple input xfrms

Stefan Agner (1):
      kbuild: set no-integrated-as before incl. arch Makefile

Stefano Brivio (2):
      ipv6/ndisc: Preserve IPv6 control buffer if protocol error handlers are called
      ip6_tunnel: Fix encapsulation layout

Steffen Klassert (2):
      xfrm: Validate address prefix lengths in the xfrm selector.
      xfrm: Fix NULL pointer dereference when skb_dst_force clears the dst_entry.

Steve Capper (1):
      arm64: hugetlb: Fix handling of young ptes

Takashi Iwai (1):
      ALSA: usx2y: Fix invalid stream URBs

Thadeu Lima de Souza Cascardo (2):
      xfrm6: call kfree_skb when skb is toobig
      test_bpf: Fix testing with CONFIG_BPF_JIT_ALWAYS_ON=y on other arches

Thomas Petazzoni (1):
      ARM: 8799/1: mm: fix pci_ioremap_io() offset check

Tobias Jungel (1):
      bonding: fix length of actor system

Wenwen Wang (4):
      net: cxgb3_main: fix a missing-check bug
      yam: fix a missing-check bug
      net: socket: fix a missing-check bug
      ethtool: fix a privilege escalation bug

Winkler, Tomas (1):
      tpm: tpm_crb: relinquish locality on error path.

Yu Zhao (1):
      cfg80211: fix use-after-free in reg_process_hint()

Yuan-Chi Pang (1):
      mac80211: fix TX status reporting for ieee80211s

Zhao Qiang (1):
      soc: fsl: qe: Fix copy/paste bug in ucc_get_tdm_sync_shift()

 Makefile                                           |   6 +-
 arch/Kconfig                                       |   8 +
 arch/arm/boot/dts/bcm63138.dtsi                    |  14 +-
 arch/arm/boot/dts/imx53-qsb-common.dtsi            |  11 +
 arch/arm/boot/dts/r8a7790.dtsi                     |   2 +-
 arch/arm/boot/dts/tegra20.dtsi                     |   2 +-
 arch/arm/mm/ioremap.c                              |   2 +-
 arch/arm64/mm/hugetlbpage.c                        |  12 +-
 arch/mips/Kconfig                                  |   1 +
 arch/mips/include/asm/compiler.h                   |  35 +++
 arch/powerpc/include/asm/topology.h                |   3 +
 arch/sparc/mm/tlb.c                                |  19 +-
 arch/x86/events/amd/uncore.c                       |  10 +
 arch/x86/events/intel/uncore_snbep.c               |  12 +-
 arch/x86/include/asm/perf_event.h                  |   8 +
 arch/x86/kernel/paravirt.c                         |   4 +-
 arch/x86/kvm/paging_tmpl.h                         |  11 +-
 arch/x86/kvm/x86.c                                 |   6 +-
 drivers/char/tpm/tpm-interface.c                   |   3 +-
 drivers/char/tpm/tpm_crb.c                         |  10 +-
 drivers/gpu/drm/i915/gvt/cmd_parser.c              |   1 +
 drivers/infiniband/hw/mlx5/main.c                  |   2 +-
 drivers/infiniband/hw/mlx5/qp.c                    |   7 +-
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c       |   2 +-
 drivers/infiniband/hw/usnic/usnic_uiom.c           |  40 ++-
 drivers/infiniband/hw/usnic/usnic_uiom.h           |   5 +-
 drivers/infiniband/sw/rxe/rxe_pool.c               |  16 +-
 drivers/infiniband/ulp/ipoib/ipoib_ib.c            |   7 +-
 drivers/md/dm-integrity.c                          |   3 +
 drivers/media/usb/uvc/uvc_driver.c                 |  11 +-
 drivers/mmc/host/dw_mmc-rockchip.c                 |   4 +-
 drivers/mtd/spi-nor/spi-nor.c                      |   6 +
 drivers/net/bonding/bond_netlink.c                 |   3 +-
 drivers/net/ethernet/amazon/ena/ena_netdev.c       |  18 +-
 drivers/net/ethernet/amd/declance.c                |  10 +-
 drivers/net/ethernet/broadcom/genet/bcmmii.c       |   9 +-
 drivers/net/ethernet/cadence/macb_main.c           |   1 +
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c    |  17 +
 drivers/net/ethernet/cisco/enic/enic_main.c        |   9 +-
 drivers/net/ethernet/emulex/benet/be_main.c        |   5 +-
 drivers/net/ethernet/freescale/fec.h               |   4 +
 drivers/net/ethernet/freescale/fec_main.c          |  24 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c |  17 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_rx.c    |  45 +--
 drivers/net/ethernet/mellanox/mlx5/core/eq.c       |   2 +-
 drivers/net/ethernet/qlogic/qed/qed_iwarp.c        |   4 +-
 drivers/net/ethernet/qlogic/qed/qed_roce.c         |  15 +-
 drivers/net/ethernet/qlogic/qed/qed_sp_commands.c  |   2 +-
 drivers/net/ethernet/qlogic/qed/qed_vf.c           |   5 +-
 .../net/ethernet/qualcomm/rmnet/rmnet_handlers.c   |   3 +
 drivers/net/ethernet/realtek/r8169.c               |   8 +-
 drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c  |   2 +-
 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c   |   4 +-
 drivers/net/hamradio/yam.c                         |   4 +
 drivers/net/phy/phy_device.c                       |  17 +
 drivers/net/phy/phylink.c                          |   2 +-
 drivers/net/phy/realtek.c                          |   2 +
 drivers/net/usb/asix_common.c                      |   3 +
 drivers/net/usb/ax88179_178a.c                     |   3 +
 drivers/net/usb/lan78xx.c                          |  21 +-
 drivers/net/usb/r8152.c                            |   3 +
 drivers/net/usb/smsc75xx.c                         |   3 +
 drivers/net/usb/smsc95xx.c                         |   3 +
 drivers/net/usb/sr9800.c                           |   3 +
 drivers/net/virtio_net.c                           |   5 +-
 drivers/net/wireless/intel/iwlwifi/fw/api/alive.h  |   4 +-
 drivers/net/wireless/intel/iwlwifi/fw/dbg.c        |  15 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rx.c        |   3 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c      |   4 +-
 drivers/net/wireless/mac80211_hwsim.c              |   3 +-
 drivers/net/wireless/marvell/libertas/if_sdio.c    |   4 +
 drivers/net/xen-netfront.c                         |  11 +-
 drivers/s390/net/qeth_core_main.c                  |  85 +++--
 drivers/scsi/aacraid/commsup.c                     |   8 +-
 drivers/scsi/ibmvscsi/ibmvfc.c                     |   6 +-
 drivers/scsi/qla2xxx/qla_init.c                    |   4 +-
 drivers/scsi/sd.c                                  |   2 +
 drivers/soc/fsl/qbman/qman.c                       |   3 +
 drivers/soc/fsl/qe/ucc.c                           |   2 +-
 drivers/usb/usbip/vhci_sysfs.c                     |  12 +-
 drivers/vhost/vhost.c                              |   2 +
 drivers/video/fbdev/pxa168fb.c                     |   6 +-
 fs/btrfs/qgroup.c                                  |   4 +-
 fs/cifs/inode.c                                    |   2 +-
 fs/fat/fatent.c                                    |   1 +
 fs/ocfs2/refcounttree.c                            |  16 +-
 include/linux/bpf.h                                |   2 +-
 include/linux/compiler_types.h                     |  12 +
 include/linux/iio/buffer-dma.h                     |   2 +-
 include/linux/mlx5/driver.h                        |  20 +-
 include/linux/phy.h                                |   4 +
 kernel/bpf/arraymap.c                              |   3 +-
 kernel/bpf/sockmap.c                               |   4 +-
 kernel/bpf/syscall.c                               |   4 +-
 kernel/events/core.c                               |  11 +-
 kernel/locking/test-ww_mutex.c                     |  10 +-
 lib/test_bpf.c                                     |   2 +-
 net/bluetooth/mgmt.c                               |   7 +-
 net/bluetooth/smp.c                                |  29 +-
 net/bluetooth/smp.h                                |   3 +-
 net/bridge/br_multicast.c                          |   9 +-
 net/bridge/br_netfilter_hooks.c                    |   3 +-
 net/core/datagram.c                                |   5 +-
 net/core/ethtool.c                                 |   8 +-
 net/core/rtnetlink.c                               |  10 +
 net/core/skbuff.c                                  |   5 +-
 net/ipv4/ip_fragment.c                             |  12 +-
 net/ipv4/ipmr.c                                    |   2 -
 net/ipv4/udp.c                                     |  20 +-
 net/ipv4/xfrm4_input.c                             |   1 +
 net/ipv4/xfrm4_mode_transport.c                    |   4 +-
 net/ipv6/addrconf.c                                |   6 +-
 net/ipv6/ip6_checksum.c                            |  20 +-
 net/ipv6/ip6_tunnel.c                              |   9 +-
 net/ipv6/mcast.c                                   |  16 +-
 net/ipv6/ndisc.c                                   |   3 +-
 net/ipv6/netfilter/nf_conntrack_reasm.c            |   2 -
 net/ipv6/udp.c                                     |   6 +-
 net/ipv6/xfrm6_input.c                             |   1 +
 net/ipv6/xfrm6_mode_transport.c                    |   4 +-
 net/ipv6/xfrm6_output.c                            |   2 +
 net/l2tp/l2tp_core.c                               |  14 +-
 net/l2tp/l2tp_core.h                               |   3 -
 net/l2tp/l2tp_debugfs.c                            |   4 +-
 net/l2tp/l2tp_netlink.c                            |   3 -
 net/llc/llc_conn.c                                 |   1 +
 net/mac80211/mesh.h                                |   3 +-
 net/mac80211/mesh_hwmp.c                           |   9 +-
 net/mac80211/status.c                              |  11 +-
 net/mac80211/tdls.c                                |   8 +-
 net/mac80211/tx.c                                  |   2 +-
 net/openvswitch/flow_netlink.c                     |   4 +-
 net/rxrpc/ar-internal.h                            |   4 +-
 net/rxrpc/call_accept.c                            |   4 +-
 net/rxrpc/conn_event.c                             |  26 +-
 net/rxrpc/input.c                                  |  54 ++--
 net/sched/cls_api.c                                |   7 +-
 net/sched/sch_api.c                                |   3 +-
 net/sched/sch_gred.c                               |   2 +-
 net/sched/sch_netem.c                              |   4 +
 net/sctp/socket.c                                  |   5 +-
 net/socket.c                                       |  11 +-
 net/wireless/nl80211.c                             |  20 +-
 net/wireless/reg.c                                 |   1 +
 net/wireless/scan.c                                |  58 +++-
 net/xfrm/xfrm_input.c                              |   1 +
 net/xfrm/xfrm_output.c                             |   4 +
 net/xfrm/xfrm_policy.c                             |   4 +
 net/xfrm/xfrm_user.c                               |  15 +
 scripts/kconfig/zconf.y                            |   4 +-
 sound/usb/usx2y/usb_stream.c                       |  23 +-
 tools/perf/Makefile                                |   4 +-
 tools/perf/tests/builtin-test.c                    |   4 +-
 tools/perf/util/setup.py                           |   2 +-
 tools/testing/nvdimm/test/nfit.c                   |  18 ++
 tools/testing/selftests/net/rtnetlink.sh           |   2 +-
 tools/testing/selftests/powerpc/ptrace/.gitignore  |   1 +
 tools/testing/selftests/powerpc/ptrace/Makefile    |   2 +-
 .../selftests/powerpc/ptrace/ptrace-hwbreak.c      | 342 +++++++++++++++++++++
 159 files changed, 1208 insertions(+), 496 deletions(-)
 create mode 100644 tools/testing/selftests/powerpc/ptrace/ptrace-hwbreak.c

BUG= chromium:901671 
TEST=Build and test on various affected systems

Change-Id: I93a82484e0da28e995c0ed28a2b5dd82454e5e17
Signed-off-by: Guenter Roeck <groeck@chromium.org>


Status: Fixed (was: Started)
Cc: yuzhao@chromium.org geohsu@chromium.org tfiga@chromium.org
Labels: Merge-Request-71
We'd like to merge this one to M-71, for b/119291953.

Philipp Zabel (1):
      media: uvcvideo: Fix driver reference counting

Project Member

Comment 5 by sheriffbot@chromium.org, Nov 13

Labels: -Merge-Request-71 Hotlist-Merge-Reject Merge-Reject-71
The bug is marked as P3 or Feature. It should not be merged as M71 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 -Merge-Reject-71 Merge-Request-71 Pri-1
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 13

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 13

Labels: merge-merged-release-R71-11151.B-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/4fee3299be69b42dfa1949fbf49d5c2641e6952a

commit 4fee3299be69b42dfa1949fbf49d5c2641e6952a
Author: Philipp Zabel <philipp.zabel@gmail.com>
Date: Tue Nov 13 23:21:45 2018

UPSTREAM: media: uvcvideo: Fix driver reference counting

commit f9ffcb0a21e1fa8e64d09ed613d884e054ae8191 upstream

kref_init initializes the reference count to 1, not 0. This additional
reference is never released since the conversion to reference counters.
As a result, uvc_delete is not called anymore when UVC cameras are
disconnected.
Fix this by adding an additional kref_put in uvc_disconnect and in the
probe error path. This also allows to remove the temporary additional
reference in uvc_unregister_video.

Fixes: 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic variable to a reference count")

Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit e75194d294421704baf4c577e504cb9c92ec7ce2)
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG= chromium:901671 ,b:119291953
TEST=build, boot & sanity check on grunt

Change-Id: I703b0712ea6c1d9f86a7adcd295e6728db798a09
Reviewed-on: https://chromium-review.googlesource.com/c/1334449
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Commit-Queue: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>

[modify] https://crrev.com/4fee3299be69b42dfa1949fbf49d5c2641e6952a/drivers/media/usb/uvc/uvc_driver.c

Labels: -Merge-Approved-71

Sign in to add a comment