New issue
Advanced search Search tips

Issue 901666 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

CSS: pointer-events keywords should serialize in lower case

Project Member Reported by ericwilligers@chromium.org, Nov 4

Issue description

visibleStroke visibleFill visiblePainted should each serialize in lower case.

https://drafts.csswg.org/cssom/#serializing-css-values

"To serialize a CSS component value depends on the component, as follows:
keyword
The keyword converted to ASCII lowercase."

This is similar to  crbug.com/882014  and  crbug.com/863741 

 
Components: Blink>Input
Status: Available (was: Untriaged)
I will take this.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582acfa6589d039b7e2b94cbe084190f0ce98b12

commit 582acfa6589d039b7e2b94cbe084190f0ce98b12
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Mon Nov 05 18:07:24 2018

CSS: serialize pointer-events keywords in lower case

https://drafts.csswg.org/cssom/#serializing-css-values

"To serialize a CSS component value depends on the component, as follows:
keyword
The keyword converted to ASCII lowercase."

Bug:  901666 
Change-Id: Iff579a363de13441c75bbebfc951095b071f6060
Reviewed-on: https://chromium-review.googlesource.com/c/1317300
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605383}
[modify] https://crrev.com/582acfa6589d039b7e2b94cbe084190f0ce98b12/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/pointer-events.html
[modify] https://crrev.com/582acfa6589d039b7e2b94cbe084190f0ce98b12/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html
[modify] https://crrev.com/582acfa6589d039b7e2b94cbe084190f0ce98b12/third_party/blink/renderer/core/css/css_properties.json5
[modify] https://crrev.com/582acfa6589d039b7e2b94cbe084190f0ce98b12/third_party/blink/renderer/core/css/css_value_keywords.json5
[modify] https://crrev.com/582acfa6589d039b7e2b94cbe084190f0ce98b12/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
[modify] https://crrev.com/582acfa6589d039b7e2b94cbe084190f0ce98b12/third_party/blink/renderer/core/layout/pointer_events_hit_rules.cc

Owner: zhuoyu.q...@samsung.com
Status: Fixed (was: Available)

Sign in to add a comment