Chrome doesn't remove .crdownload files
Reported by
world.best.hacker.h403@gmail.com,
Nov 3
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Open an incognito window 2. Navigate to https://storage.googleapis.com/tensorflow/windows/cpu/tensorflow-1.11.0-cp35-cp35m-win_amd64.whl 3. Start downloading 4. Exit the incognito window while the file is downloading 5. Observe that useless .crdownload file remains on your desktop What is the expected behavior? The .crdownload file should be removed. What went wrong? Chrome keeps it for some reason. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 70.0.3538.77 Channel: stable OS Version: 6.3 Flash Version: / The issue is seen on 67.0.3396.87
,
Nov 4
@arben, your comments seem irrelevant to this issue.
,
Nov 4
,
Nov 5
Able to reproduce the issue on chrome reported version# 70.0.3538.77 and on latest chrome# 72.0.3602.0 using Windows-10, Mac 10.12.6 and Ubuntu 17.10 with steps mentioned in comment# 0. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged. Thanks!
,
Nov 5
,
Nov 5
,
Nov 6
I think this is related to crbug.com/837533. Given incognito mode is more important from the point of view of unwanted remaining files, partial downloads are neglected in regular mode as well. qinmin@, Could you please take a look?
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c534927ec758f7c97b4c3615ba1a6d2620a68d20 commit c534927ec758f7c97b4c3615ba1a6d2620a68d20 Author: Min Qin <qinmin@chromium.org> Date: Thu Nov 15 22:55:09 2018 Remove in-progress download files when DownloadManagerImpl shuts down Shutting down the download manager will not remove in-progress file today. However, in downloadItemImpl::InterruptWithPartialState(), if the download is in a resuming state while download manager got shudown, then the file is removed. This behavior is not consistent. Since desktop already has the warning dialog when user tries to shut down Chrome while there are in-progress download, we don't need to keep the in-progress files. Clicking shut down pretty much means canceling the download. BUG= 901642 Change-Id: I7bcf30b21fca59bf2cc57a23f0a41d49f0639ce8 Reviewed-on: https://chromium-review.googlesource.com/c/1321574 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608563} [modify] https://crrev.com/c534927ec758f7c97b4c3615ba1a6d2620a68d20/components/download/internal/common/download_utils.cc
,
Nov 15
,
Nov 16
Able to reproduce the issue on chrome reported version# 70.0.3538.77 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #72.0.3612.0 as per the comment#0 Attaching screen cast for reference. Observed ".crdownload file got removed" Hence, the fix is working as expected. Adding the verified label. Thanks! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by arben...@gmail.com
, Nov 419.9 MB
19.9 MB Download