New issue
Advanced search Search tips

Issue 901640 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in chrome_pdf::OutOfProcessInstance::ScrollToPage

Project Member Reported by ClusterFuzz, Nov 3

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5759679256592384

Fuzzer: ifratric_pdf_generic
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  chrome_pdf::OutOfProcessInstance::ScrollToPage
  CPDFSDK_ActionHandler::DoAction_GoTo
  CPDFSDK_ActionHandler::DoAction_NoJs
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=570881:570890

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5759679256592384

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 3

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 3

Cc: art-sn...@yandex-team.ru
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Rework of loading of CPDF_Document. by art-snake@yandex-team.ru - https://pdfium.googlesource.com/pdfium/+/20eca1e383b7dce69cd791d42bda3558a3966301

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: kkaluri@chromium.org
Labels: M-71
Owner: hnakashima@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "cpdfsdk_actionhandler.cpp" suspecting the below Cl might have caused this issue

Suspect CL: https://pdfium.googlesource.com/pdfium.git/+/9d784c291714b703b16185e69860a3797de85b6c

hnakashima@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Owner: tsepez@chromium.org
I don't think it was my change, it's not in the regression range.
Looks to be a longstanding issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e175a79eada33283097181cf739a5941138148

commit e2e175a79eada33283097181cf739a5941138148
Author: Tom Sepez <tsepez@chromium.org>
Date: Tue Nov 06 21:51:29 2018

OutOfProcessEngine::ScrollToPage(): check for null engine

This callback may be reached as part of a close document action
after the engine has been destroyed. Further inspection of the code
shows that the same might also happen for Print().

Bug:  901640 
Change-Id: I8faaeaf72adb37441f9e9c977093273c9e055e91
Reviewed-on: https://chromium-review.googlesource.com/c/1320810
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605829}
[modify] https://crrev.com/e2e175a79eada33283097181cf739a5941138148/pdf/out_of_process_instance.cc

Project Member

Comment 7 by ClusterFuzz, Nov 7

ClusterFuzz has detected this issue as fixed in range 605826:605862.

Detailed report: https://clusterfuzz.com/testcase?key=5759679256592384

Fuzzer: ifratric_pdf_generic
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  chrome_pdf::OutOfProcessInstance::ScrollToPage
  CPDFSDK_ActionHandler::DoAction_GoTo
  CPDFSDK_ActionHandler::DoAction_NoJs
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=570881:570890
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=605826:605862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5759679256592384

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Nov 7

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5759679256592384 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment