Issues with theme tab text colour (for inactive windows and hover effect)
Reported by
fadil.no...@gmail.com,
Nov 3
|
|||||||||
Issue descriptionChrome Version : 72.0.3600.1 OS Version: 10.0 --- Test URL: https://chrome.google.com/webstore/detail/black-red-shards/jpjlkkaalgfbbegfnjoclhfidancjpch?hl=en-GB What steps will reproduce the problem? 1. Install the Black Red Shards theme. 2. Set the window as inactive. What is the expected result? The tab text should retain its custom colour, in this case red. Here's a screenshot from v70.0.3538.77: https://i.imgur.com/7dGXh6P.png What happens instead of that? The tab text loses its custom colour and turns grey instead. Here's a screenshot from v72.0.3600.1: https://i.imgur.com/q6rmOx6.png . In this particular case, it looks bad as the contrast between the tab colour and tab text is reduced. Please provide any additional information below. Attach a screenshot if possible. Reproduced with other themes (e.g. Material Incognito Dark, Blue Red Shards, etc). --- UserAgentString: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3600.1 Safari/537.36
,
Nov 12
Able to reproduce the issue on chrome version# 72.0.3600.0 and the issue is not seen on #70.0.3538.77 with the sample URL and steps provided in comment# 0 using Windows-10. We will provide bisect information and other OS behaviour soon. Hence adding Needs-Bisect label and marking it as Untriaged. Thanks.
,
Nov 13
Able to reproduce the issue on reported version 72.0.3600.1 and latest chrome 72.0.3608.0 using Mac 10.12.6, Ubuntu 14.04 and Windows-10, hence providing Bisect Info Bisect Info: ================ Good build: 71.0.3555.0 Bad build: 71.0.3556.0 You are probably looking for a change made after 591873 (known good), but no later than 591874 (first known bad). https://chromium.googlesource.com/chromium/src/+log/1adfd6531bf33724c15b31e77a406e8e850c55d8..059b37110ad2d6dcd3c177b66f26bbfdfe197386 Change-Id: Icf9ae2aee881a4927d70d78ee1c7773c016ad1bc Reviewed-on: https://chromium-review.googlesource.com/1196010 @Collin Baker: Please confirm the issue and help in re-assigning if it is not related to your change. Adding ReleaseBlock-Stable for M-71, feel free to remove it if not applicable. Thanks!
,
Nov 13
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you. Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.
,
Nov 13
,
Nov 13
,
Nov 14
**UI mass Triage** Still able to reproduce the issue on all OS using chrome latest Canary-72.0.3608.0 as per C#0.Adding respective labels. Thanks..!
,
Nov 15
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you. Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.
,
Nov 15
Based on the offline chat with collinbaker@ this isn't a major issue which should be considered as Stable blocker and this issue is specific to this theme, hence removing stable blocker.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d71e41b95b9d40bc36eaf23815fc63c0ed3b49fa commit d71e41b95b9d40bc36eaf23815fc63c0ed3b49fa Author: Collin Baker <collinbaker@chromium.org> Date: Fri Nov 16 17:30:46 2018 Fix tab colors for custom themes This change: * removes COLOR_TAB_TEXT_INACTIVE and instead simply alpha-blends COLOR_TAB_TEXT * removes disabled unit test that uses COLOR_TAB_TEXT_INACTIVE * uses COLOR_BACKGROUND_TAB_TEXT_INACTIVE directly if a theme provides it Bug: 901610 , 859243 Change-Id: I7db13a7719284ac3e27ec3bfc122d6381430df26 Reviewed-on: https://chromium-review.googlesource.com/c/1334419 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608831} [modify] https://crrev.com/d71e41b95b9d40bc36eaf23815fc63c0ed3b49fa/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/d71e41b95b9d40bc36eaf23815fc63c0ed3b49fa/chrome/browser/themes/theme_properties.cc [modify] https://crrev.com/d71e41b95b9d40bc36eaf23815fc63c0ed3b49fa/chrome/browser/themes/theme_properties.h [modify] https://crrev.com/d71e41b95b9d40bc36eaf23815fc63c0ed3b49fa/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc [modify] https://crrev.com/d71e41b95b9d40bc36eaf23815fc63c0ed3b49fa/chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc
,
Nov 17
,
Nov 22
,
Nov 26
This should be fixed in Canary. The text is still dimmed (which is intended behavior) but it stays red and is more readable. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by susan.boorgula@chromium.org
, Nov 4Labels: Needs-Triage-M72