New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901593 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Touchpad overscroll history navigation doesn't work on non-touchscreen laptops

Reported by bendo...@gmail.com, Nov 3

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Steps to reproduce the problem:
1. Turn on touchpad overscroll history navigation in chrome://flags on a laptop with no touchscreen, but with a Precision Touchpad.
2. Perform a two-finger back/forward swipe on touchpad.
3. Observe that nothing happens.

What is the expected behavior?
Back/forward overscroll navigation occurs.

What went wrong?
If the laptop is not touch capable:

GetSystemMetrics(SM_DIGITIZER) = 0 -> IsTouchDevicePresent() = false -> Browser::CanOverscrollContent() = false

https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/browser.cc#1085

Without CanOverscrollContent, I can't overscroll with my Precision Touchpad, so the history navigation gestures don't work.

Did this work before? N/A 

Chrome version: 70.0.3538.77  Channel: stable
OS Version: 10.0
Flash Version: 

I have a Yoga 920 that does have a touchscreen (which I don't use), and touchpad overscroll history navigation works perfectly.

I have an XPS 15 that does not have a touchscreen (which I obviously don't use), and touchpad overscroll history navigation doesn't work.

Presence or absence of a touch*SCREEN* should not dictate the behavior of my touch*PAD*.
 
Labels: Needs-Triage-M70
Components: -UI UI>Browser>Navigation
Labels: Triaged-ET TE-NeedsTriageFromHYD
The issue require a laptop with no touchscreen, but with a Precision Touchpad and ET team doesn't have a laptop with specification as mentioned above. Hence, routing it to inhouse team for further triaging of the issue.

Thanks...!!
Cc: sadrul@chromium.org
Labels: -TE-NeedsTriageFromHYD
+sadrul@ - one of reviewers of r297771 from #c1
Cc: gklassen@chromium.org
Owner: moh...@chromium.org
Now that we don't actually need a screenshot anymore for gesture-nav, I think it'd make sense to allow this for non-touchscreen laptops too.

--> mohsen@ what do you think?
Cc: chaopeng@chromium.org moh...@chromium.org
Components: -UI>Browser>Navigation UI>Browser>Navigation>GestureNav
Owner: ----
Status: Available (was: Unconfirmed)
I agree.

We're not taking screenshots on navigation anymore (since r536956 screenshot mode is not default; since r602997 screenshot option is removed from flags; code will be removed in a milestone).

Also, I believe more and more of modern Windows laptops support precision touchpad (with no touchscreen), so it doesn't make sense to disable the feature based on touchscreen availability anymore.
Hi mohsen@, do you have plan to remove these?
No immediate plans. Maybe in a week or two. Feel free to grab it if you would like.
Is there a way to override IsTouchDevicePresent() through command line switches to enable the overscroll history navigation? I have tried  --touch-events=enabled but it didn't seem to work.
Cc: e...@chromium.org skobes@chromium.org ananta@chromium.org ebra...@gnu.org
 Issue 913841  has been merged into this issue.
Really need this fixed... Browsing is a chore. When it's easier to navigate in Edge there's something terribly wrong.
Owner: moh...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e1ffbb1207316f0647bf69bc7888ab9e1a83f5e

commit 2e1ffbb1207316f0647bf69bc7888ab9e1a83f5e
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Fri Dec 21 19:48:32 2018

Allow gesture-nav regardless of touchscreen availability

Previously, gesture-nav (overscroll history navigation) was enabled on
Windows only when the device had touchscreen. The reasoning behind this
was that devices normally didn't have precision touchpad, so gesture-nav
was only useful with touchscreen devices. Moreover, gesture-nav used to
take a screenshot on each page navigation which is costly. To avoid this
unnecessary cost when the feature is not useful, gesture-nav was
disabled when there was no touchscreen. However, this has changed as
there are more Windows devices with precision touchpad that can benefit
from this feature and no screenshot is taken on page navigations
anymore. It makes sense now to remove this restriction.

BUG= 901593 

Change-Id: I791dec022771d960a96efbb376ea90779c7a064c
Reviewed-on: https://chromium-review.googlesource.com/c/1387826
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618573}
[modify] https://crrev.com/2e1ffbb1207316f0647bf69bc7888ab9e1a83f5e/chrome/browser/ui/browser.cc

Status: Fixed (was: Assigned)

Sign in to add a comment