[📍] 500 error on Job page when Gerrit patch is deleted |
|
Issue description1. Create a try job with a Gerrit patch. 2. Delete the patch in Gerrit. 3. Pinpoint shows a 500 error when trying to display the try job. This is because Pinpoint pings Gerrit for the patch subject, author, and URL to display on the Job page, and Gerrit returns a 404 Not Found error. One option is to store it in the datastore.
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/6bdde7993dfd75300b90a2fc792dc60fd1d36568 commit 6bdde7993dfd75300b90a2fc792dc60fd1d36568 Author: Dave Tu <dtu@chromium.org> Date: Wed Jan 16 02:07:06 2019 [pinpoint] Cache Commit and Patch details in the Datastore. Add a CommitCache model to the datastore that stores some basic info (url, timestamp, author, subject, etc.) about Commits and Patches. This reduces our dependency on Gitiles, which can take several seconds to fetch one Commit's info. Datastore entities are automatically cached in memcache and the in-context cache, so it should now take micro- or milliseconds per Commit. A Job can have dozens of Commits. This also allows us to retain Patch into for deleted Patches. Bug: chromium:920874 Bug: chromium:901579 Change-Id: Ie79bf9e050a8d29182e04ade07d5d9b64ffeb629 Reviewed-on: https://chromium-review.googlesource.com/c/1409926 Commit-Queue: Dave Tu <dtu@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Simon Hatch <simonhatch@chromium.org> [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/test.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/change/commit.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/job.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/change/change_test.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/common/utils.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/change/commit_test.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/change/patch.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/file_bug.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/update_dashboard_stats.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/common/utils_test.py [add] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/change/commit_cache_test.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/job_test.py [modify] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/change/patch_test.py [add] https://crrev.com/6bdde7993dfd75300b90a2fc792dc60fd1d36568/dashboard/dashboard/pinpoint/models/change/commit_cache.py
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98a9d966a546063a0c058d62e414fe41284105e3 commit 98a9d966a546063a0c058d62e414fe41284105e3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Jan 16 04:47:37 2019 Roll src/third_party/catapult 78448d90081e..6bdde7993dfd (1 commits) https://chromium.googlesource.com/catapult.git/+log/78448d90081e..6bdde7993dfd git log 78448d90081e..6bdde7993dfd --date=short --no-merges --format='%ad %ae %s' 2019-01-16 dtu@chromium.org [pinpoint] Cache Commit and Patch details in the Datastore. Created with: gclient setdep -r src/third_party/catapult@6bdde7993dfd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:920874,chromium:901579 TBR=sullivan@chromium.org Change-Id: I0966956724ecaf9ded76ef21b3a3fd5840f3f928 Reviewed-on: https://chromium-review.googlesource.com/c/1414073 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623109} [modify] https://crrev.com/98a9d966a546063a0c058d62e414fe41284105e3/DEPS |
|
►
Sign in to add a comment |
|
Comment 1 by dtu@chromium.org
, Jan 11