New issue
Advanced search Search tips

Issue 901572 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Nov 3
Cc:
hidehiko@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

TestLogger in Tast jslog package fails with "JS logs mismatch"

Project Member Reported by derat@chromium.org, Nov 3 
There may be a race in the jslog package's unit tests. I saw the following failure when I ran "FEATURES=test emerge-caroline tast-local-tests-cros", but it doesn't seem to happen consistently:

--- FAIL: TestLogger (0.00s)                                                                                                                                                                                                                                                             jslog_test.go:74: JS logs mismatch: got "================================================================== fooURL\n50789-11-20 05:06:40 [type] message1\n\n================================================================== barURL\n50789-11-20 05:06:40 [type] message2\n\n", want "================================================================== fooURL\n2018-10-26 19:20:28 [type] message1\n\n================================================================== barURL\n2018-10-26 19:20:28 [type] message2\n\n"                             --- FAIL: TestLogger_ErrorStackTrace (0.00s)                                                                                                                                                                                                                                    
        jslog_test.go:74: JS logs mismatch: got "================================================================== fooURL\n50789-11-20 05:06:40 [error] message\n\tat foo (chrome://foo [11:22])\n\tat bar (chrome://bar [33:44])\n\n", want "==================================
================================ fooURL\n2018-10-26 19:20:28 [error] message\n\tat foo (chrome://foo [11:22])\n\tat bar (chrome://bar [33:44])\n\n"
--- FAIL: TestLogger_InfoStackTrace (0.00s)
        jslog_test.go:74: JS logs mismatch: got "================================================================== fooURL\n50789-11-20 05:06:40 [info] message\n\n", want "================================================================== fooURL\n2018-10-26 19:20:28 [info]
 message\n\n"
FAIL                                                                                                               
FAIL    chromiumos/tast/local/chrome/jslog      0.044s

We're apparently not running unit tests, which is tracked by  issue 901570 .

Comment 1 by derat@chromium.org, Nov 3

Status: WontFix (was: Untriaged)
Looking more closely, I'm seeing very strange timestamps: "50789-11-20 05:06:40" instead of "2018-10-26 19:20:28". The test passes when I run it using fast_build.sh, but it fails when I use emerge.

I synced recently. After emerging dev-go/cdp, the test seems to pass. So presumably this was just a mismatch in my local checkout. Sorry for the noise.

Comment 2 by nya@chromium.org, Nov 5 

That's a bug I fixed in the upstream recently. Latest cdp package should work.
►

Sign in to add a comment