New issue
Advanced search Search tips

Issue 901568 link

Starred by 1 user
Status: Fixed
Owner:
zhizhouy@chromium.org
Closed: Nov 6
Cc:
llozano@chromium.org
cmt...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain


Participants' hotlists:
bugsincrosperf


Sign in to add a comment

all_crosbolt_perf benchmarks are not constructed correctly

Project Member Reported by zhizhouy@chromium.org, Nov 3 
The all_crosbolt_perf benchmark should belong to telemetry_Crosperf benchmark suite, but in experiment_factory.py file, it is excluded from telemetry_Crosperf suite.

It leads to a problem that benchmarks inside it cannot be split correctly when running crosperf test, which causes the run failing.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/265c5acbe70d8769f60260f80921338c15b834b1

commit 265c5acbe70d8769f60260f80921338c15b834b1
Author: Zhizhou Yang <zhizhouy@google.com>
Date: Tue Nov 06 06:09:28 2018

crosperf: move all_crosbolt_perf benchmark to telemetry_crosperf suite

This patch fixes the issue that all_crosbolt_perf cannot run correctly
with crosperf. The construction of this benchmark should sit in
telemetry suite.

BUG= chromium:901568 
TEST=ran all_crosbolt_perf benchmark with crosperf on local DUT

Change-Id: I94018cd7ad8348238085270b92c5a7e44ae4bbaa
Reviewed-on: https://chromium-review.googlesource.com/1316708
Commit-Ready: Zhizhou Yang <zhizhouy@google.com>
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/265c5acbe70d8769f60260f80921338c15b834b1/crosperf/experiment_factory.py

Comment 2 by zhizhouy@chromium.org, Nov 6

Status: Fixed (was: Started)
Marking this as fixed.
►

Sign in to add a comment