[Merge Request M71] Add migration origin in GetUploadDetailsRequest |
|||||
Issue descriptionRequesting to merge CL adding migration origin in GetUploadDetailsRequest. https://chromium-review.googlesource.com/c/chromium/src/+/1306776 This CL adds the origin (checkout flow / settings page) in the migration request so that in Payments server metrics we know the origin thus can analyze the metrics better. Have tested in Canary 72.0.3599.0. Verified the origin was correctly set in the requests and can be seen in the log. And verified the whole flow works as expected. Thanks!
,
Nov 3
Approving merge to M71 branch 3578 based on comment #0. Please merge ASAP. Thank you.
,
Nov 3
Successfully merged to 3578; closing bug.
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0 commit 280ba8e2ff8c9146fd911b1d8868dbe9698cecf0 Author: siyua <siyua@chromium.org> Date: Sat Nov 03 02:05:14 2018 Add migration origin in GetUploadDetailsRequest So that in Payments server side logging/metrics we know which source the request comes from. For normal Chrome Upstream, we default this field to UNKNOWN. Bug: 901562 Change-Id: I39e614fe0cd8747fb26e41e8da77dab574cd0f4e Reviewed-on: https://chromium-review.googlesource.com/c/1306776 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603969}(cherry picked from commit 750c0e08f43504d83f87612008da71313de1135d) Reviewed-on: https://chromium-review.googlesource.com/c/1316550 Cr-Commit-Position: refs/branch-heads/3578@{#484} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0/components/autofill/core/browser/local_card_migration_manager.cc [modify] https://crrev.com/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0/components/autofill/core/browser/payments/payments_client.cc [modify] https://crrev.com/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0/components/autofill/core/browser/payments/payments_client.h [modify] https://crrev.com/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0/components/autofill/core/browser/payments/payments_client_unittest.cc [modify] https://crrev.com/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0/components/autofill/core/browser/payments/test_payments_client.cc [modify] https://crrev.com/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0/components/autofill/core/browser/payments/test_payments_client.h
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/280ba8e2ff8c9146fd911b1d8868dbe9698cecf0 Commit: 280ba8e2ff8c9146fd911b1d8868dbe9698cecf0 Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-11-03 02:05:14 +0000 UTC Add migration origin in GetUploadDetailsRequest So that in Payments server side logging/metrics we know which source the request comes from. For normal Chrome Upstream, we default this field to UNKNOWN. Bug: 901562 Change-Id: I39e614fe0cd8747fb26e41e8da77dab574cd0f4e Reviewed-on: https://chromium-review.googlesource.com/c/1306776 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603969}(cherry picked from commit 750c0e08f43504d83f87612008da71313de1135d) Reviewed-on: https://chromium-review.googlesource.com/c/1316550 Cr-Commit-Position: refs/branch-heads/3578@{#484} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sheriffbot@chromium.org
, Nov 3