This issue doesn't happen in Laptop mode.

Repro video link:
https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/901550/

Feedback report:
https://listnr.corp.google.com/report/85760893507

ovanieva@ to triage

<Bulk edit> Reminder M71 Stable is approaching. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thanks

<BULK EDIT> Reminder we nearinf M71 Stable. Please review this issue and update with your plan on next actions. Thanks.

@ovanieva - Can you please provide an update for this issue? This is marked RBS and stable is approaching soon. Thanks

This bug isn't getting attention; the RBS will be removed if not updated soonish.  Assume it's really not a RBS, esp as a P2.

Removing the RBS since no meaningful updates in November.   If it needs to be an RBS please retag, reassign, and escalate.  Thanks

msw, something is busted on minimize/restore

mukai, I'm not very familiar with tablet mode. Should the shortcut viewer have a minimize button? I don't see one for browser windows or packaged apps.

Maybe we just need to suppress the minimize button somehow.

I can repro on linux-chromeos with --ash-debug-shortcuts and Ctrl-Alt-Shift-T.
I also hit this DCHECK crash when clicking on the shelf item a second time when it's black.
(1) run: chrome --ash-debug-shortcuts
(2) open a browser window if one isn't open
(3) enter tablet mode with Ctrl-Alt-Shift-T
(4) launch the ksv with Ctrl-Alt-/
(5) click the minimize button on the ksv window
(6) click the ksv shelf item -> get black screen
(7) click the ksv shelf item again -> get dcheck crash:

[213336:213336:1203/143634.508034:FATAL:window.cc(244)] Check failed: !visible_ || layer()->GetTargetOpacity() > 0.0f. 
#0 0x7f6f1af48ebf base::debug::StackTrace::StackTrace()
#1 0x7f6f1ae788ab logging::LogMessage::~LogMessage()
#2 0x7f6f1629b33f aura::Window::Show()
#3 0x7f6f14e5b8dd views::NativeWidgetAura::Show()
#4 0x7f6f14e3d70e views::Widget::Show()
#5 0x5598468a5c9b ChromeLauncherController::ActivateWindowOrMinimizeIfActive()
#6 0x559846ac45e7 AppWindowLauncherItemController::ShowAndActivateOrMinimize()
#7 0x559846ac4437 AppWindowLauncherItemController::ItemSelected()
#8 0x7f6f1411b93c ash::mojom::ShelfItemDelegateStubDispatch::AcceptWithResponder()
#9 0x7f6f140787f6 ash::mojom::ShelfItemDelegateStub<>::AcceptWithResponder()

Yeah, I suspect the KSV app just needs to know Ash is in tablet mode and/or that it should hide the minimize button.
+CC evan for window frame thoughts, I can take a closer look if needed.

Actually +CC Evan

Evan, do you think we might not be propagating kResizeBehaviorKey / kResizeBehavior_Property correctly?

Not sure about that property. What leads you to ask that?

You can minimize in tablet mode, you just can't toggle between restored and maximized. See DefaultCaptionButtonModel.

From #14 it looks like step (6) is somehow failing, the dcheck is just revealing that step (6) left us in a broken state.

I filed  Issue 912973  to track the DCHECK in comment #14 (and another DCHECK).

I think the KSV window should probably resize to fill the screen and hide the titlebar (with caption buttons) in Tablet Mode, like the Task Manager (Search-Esc). I haven't observed any other windows showing caption buttons in Tablet Mode...

Other windows have caption buttons in tablet mode, but they're inside immersive-style dropdowns.

Why is the KSV limited to less than the full screen size? It's not like it couldn't make use of the extra space.

> I think the KSV window should probably resize to fill the screen and hide the titlebar (with caption buttons) in Tablet Mode, like the Task Manager (Search-Esc).

agreed! Sorry, should have read more closely.

The black window issue is not limited to the KSV, it also repros for app windows:
1) Pin Chrome Web Store to the shelf
2) Right click the shelf item, select "New window" in the "New tab" submenu
3) Click the webstore shelf item to open a new window.
4) Enter tablet mode (--ash-debug-shortcuts Ctrl-Alt-Shift-T)
5) Hover the top of the screen to reveal the webstore window titlebar with caption buttons.
6) Click the minimize caption button
7) Click the web store shelf item again, attempting to show the window.
Expected: The web store window is visible.
Actual: A black window is showing.

I wonder if this is a recent regression? Re-titling and removing the KSV tag